Add support to parse antiSMASH v6 results #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If parsing v5 and v6 is the same, we can just change the logic of that one line to include all versions >5.
|
Awesome @reslp -- I simplified to just capture versions >= 5. Can you test if this works? Just a little bit less code redundancy. |
|
Yes sure will run this again and report back. Makes sense to only use >=5 of course. I added the whole code in anticipation of possible format changes in v6. But this can be added later of course if needed. |
|
Just tested this with only smash_version >=5. Can confirm it works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Jon,
I realized that AntiSMASH has started to transition to version 6 just recently. I have therefore added support to parse this correctly. Basically I followed what you did to distingush between v4 and v5. From what I saw v6 format is not different from v5 (yet). However with the missing elif to catch v6 results will not be parsed and funannotate annotate fails at the diamond crosslinking step with MIBig because antismash output files are empty.
I have tested the code and it works. Antismash V6 results are parsed correctly and funannotate annotate also completes without error.
Hope this helps!
all the best,
Philipp