Fix number viewer for big ints and ratios, fixes #335

nextjournal · Dec 13, 2022 · 766400e · a1exsh · Dec 14, 2022 · a1exsh
1 parent 0bf2437
commit 766400e
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/resources/viewer-js-hash b/resources/viewer-js-hash
@@ -1 +1 @@
-3g3hotfUsaHvvKuPkMjwmjSbbLAA
+dyr9onTb92755K1KbbSbPikDEDv
diff --git a/src/nextjournal/clerk/viewer.cljc b/src/nextjournal/clerk/viewer.cljc
@@ -677,7 +677,11 @@
    :page-size 80})
 
 (def number-viewer
-  {:pred number? :render-fn 'nextjournal.clerk.render/render-number})
+  {:pred number?
+   :transform-fn (update-val #(cond-> %
+                                (or (instance? clojure.lang.Ratio %)
+                                    (instance? clojure.lang.BigInt %)) pr-str))
+   :render-fn 'nextjournal.clerk.render/render-number})
 
 (def number-hex-viewer
   {:name :number-hex :render-fn '(fn [num] (nextjournal.clerk.render/render-number (str "0x" (.toString (js/Number. num) 16))))})

diff --git a/test/nextjournal/clerk/viewer_test.clj b/test/nextjournal/clerk/viewer_test.clj
@@ -122,6 +122,12 @@
     (is (match? {:nextjournal/value nil, :nextjournal/viewer {:name :html}}
                 (v/present (v/html nil)))))
 
+  (testing "big ints and ratios are represented as strings (issue #335)"
+    (is (match? {:nextjournal/value "1142497398145249635243N"}
+                (v/present 1142497398145249635243N)))
+    (is (match? {:nextjournal/value "10/33"}
+                (v/present 10/33))))
+
   (testing "opts are not propagated to children during presentation"
     (let [count-opts (fn [o]
                        (let [c (atom 0)]