-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SSR explodes #505
Comments
This small doc works here: mk@mkair ~/d/test> cat ssr.clj
;; # Testing SSR
(inc 41)
mk@mkair ~/d/test> clj -Sdeps '{:deps {io.github.nextjournal/clerk {:mvn/version "0.13.842"}}}'
Clojure 1.11.1
user=> ((requiring-resolve 'nextjournal.clerk/build!) {:paths ["ssr.clj"] :ssr true})
👷🏼 Clerk is building 1 notebooks…
🧐 Parsing… Done in 47.629ms. ✅
🔬 Analyzing… Done in 66.117ms. ✅
🔨 Building "ssr.clj"… Done in 6.871ms. ✅
🧱 Server Side Rendering… Done in 1251.799ms. ✅
📦 Static app bundle created in 1260.527ms. Total build time was 1382.309ms.
"📦 Static app bundle created in 1260.527ms. Total build time was 1382.309ms.\n"
user=>
mk@mkair ~/d/test [SIGINT]> node --version
v20.0.0 Can you check if that fails for you as well so we can see if it's about the doc or the environment? |
looks like it is the doc :/ the ssr.clj above renders |
@hiredman can you share your doc or a failing excerpt? |
I removed a vega-lite chart and now it renders |
All viewers which manipulate DOM nodes as vegalite or plotly aren't suitable for SSR builds because we're generating html using node at the moment. We should at least try to make it clear in a more informative error? |
This runs for a while
Then spits out what seems to be the rendering of the notebook as html as part of an error message that ends with:
The text was updated successfully, but these errors were encountered: