Skip to content

Commit

Permalink
[deps test] bull 2.x + ioredis [Closes #11]
Browse files Browse the repository at this point in the history
  • Loading branch information
doublerebel committed Dec 23, 2016
1 parent 5f0c241 commit 6dca912
Show file tree
Hide file tree
Showing 5 changed files with 21 additions and 9 deletions.
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,14 +37,14 @@
},
"homepage": "https://github.com/nextorigin/el-borracho-stats#readme",
"devDependencies": {
"bull": "^1.0.0",
"bull": "^2.0.0",
"chai": "^3.5.0",
"coveralls": "^2.11.15",
"iced-coffee-coverage": "^1.0.21",
"iced-coffee-script": "^108.0.11",
"ioredis": "^2.4.2",
"istanbul": "^0.4.5",
"mocha": "^3.2.0",
"redis": "^2.6.3",
"sinon": "^1.17.6"
},
"peerDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion src/models/stats.coffee
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ class ElBorrachoStats
callback()

updateLock: (callback) =>
@redis.EXPIRE @statistician, @expire, callback
@redis.expire @statistician, @expire, callback

unlock: (callback = ->) =>
await @redis.del @statistician, defer err
Expand Down
10 changes: 9 additions & 1 deletion test/el-borracho-stats.coffee
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
ElBorrachoStats = require "../src/models/stats"
ElBorrachoStatsController = require "../src/el-borracho-stats"

redis = require "redis"
redis = require "ioredis"
errify = require "errify"
mocha = require "mocha"
{expect} = require "chai"
Expand Down Expand Up @@ -62,6 +62,7 @@ describe "ElBorrachoStatsController", ->
multi = client.multi()
multi.set key, i * 2 for key, i in statKeys
multi.exec done
return

afterEach (done) ->
ideally = errify done
Expand All @@ -74,6 +75,7 @@ describe "ElBorrachoStatsController", ->
multi = client.multi()
multi.del key for key in cleanup
multi.exec done
return

it "should callback with error if fetch fails", (done) ->
instance.store.redis.mget = (_, callback) -> callback new Error "fake"
Expand Down Expand Up @@ -164,6 +166,7 @@ describe "ElBorrachoStatsController", ->
multi = client.multi()
multi.set key, i * 2 for key, i in statKeys
multi.exec done
return

afterEach (done) ->
ideally = errify done
Expand All @@ -176,6 +179,7 @@ describe "ElBorrachoStatsController", ->
multi = client.multi()
multi.del key for key in cleanup
multi.exec done
return

it "should callback with error if fetch fails", (done) ->
instance.store.redis.get = (_, callback) -> callback new Error "fake"
Expand Down Expand Up @@ -221,6 +225,7 @@ describe "ElBorrachoStatsController", ->
multi = client.multi()
multi.set key, i * 2 for key, i in statKeys
multi.exec done
return

afterEach (done) ->
ideally = errify done
Expand All @@ -233,6 +238,7 @@ describe "ElBorrachoStatsController", ->
multi = client.multi()
multi.del key for key in cleanup
multi.exec done
return

it "should callback with error if fetch fails", (done) ->
instance.store.redis.mget = (_, callback) -> callback new Error "fake"
Expand Down Expand Up @@ -328,6 +334,7 @@ describe "ElBorrachoStatsController", ->
multi = client.multi()
multi.set key, i + 2 for key, i in statKeys
multi.exec done
return

afterEach (done) ->
ideally = errify done
Expand All @@ -340,6 +347,7 @@ describe "ElBorrachoStatsController", ->
multi = client.multi()
multi.del key for key in cleanup
multi.exec done
return

it "should callback with error if fetch fails", (done) ->
instance.store.redis.get = (_, callback) -> callback new Error "fake"
Expand Down
12 changes: 8 additions & 4 deletions test/stats.coffee
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
ElBorrachoStats = require "../src/models/stats"

redis = require "redis"
redis = require "ioredis"
errify = require "errify"
mocha = require "mocha"
{expect} = require "chai"
Expand Down Expand Up @@ -109,9 +109,11 @@ describe "ElBorrachoStats", ->

beforeEach (done) ->
instance.lock done
return

afterEach (done) ->
instance.unlock done
return

describe "##lock", ->
it "should set the lock in redis", (done) ->
Expand Down Expand Up @@ -194,17 +196,18 @@ describe "ElBorrachoStats", ->
multi = client.multi()
multi.del key for key in statKeys
multi.exec done
return

it "should throw an error if lock update failed", (done) ->
handler = dontCatch()
_EXPIRE = client.EXPIRE
client.EXPIRE = (_, __, callback) -> callback new Error "fake"
_expire = client.expire
client.expire = (_, __, callback) -> callback new Error "fake"

expectation = (err) ->
expect(err).to.be.an.instanceof Error
expect(err.toString()).to.match /fake/

client.EXPIRE = _EXPIRE
client.expire = _expire

handler.restore()
done()
Expand Down Expand Up @@ -320,6 +323,7 @@ describe "ElBorrachoStats", ->
multi = client.multi()
multi.del key for key in statKeys
multi.exec done
return

describe "##fetch", ->
it "should callback with totals for queue", (done) ->
Expand Down
2 changes: 1 addition & 1 deletion test/worker.coffee
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
ElBorrachoStats = require "../src/models/stats"
ElBorrachoStatsWorker = require "../src/controllers/worker"

redis = require "redis"
redis = require "ioredis"
Bull = require "bull"
errify = require "errify"
mocha = require "mocha"
Expand Down

0 comments on commit 6dca912

Please sign in to comment.