FetchPairsHelper: index by IEntity->getPersistedId #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if key is IEntity use persistedId instead of __tostring()
|
I would rather implement __toString in entity. Such conditions in fetchPairs does not seem right. |
|
I already use __toString for string representation of entity. For product __toString return its name, for page __toString returns title, which is the purpose of __toString method, that string representation is not unique and should not be used for indexing |
|
Let's introduce an interface! :-) What do you think? IHasKeyIdentifier? :) |
|
I plan to support sth like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if key is IEntity use persistedId instead of __tostring()