Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic endpoint interactions request verifier #261

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

TAG-Epic
Copy link
Member

@TAG-Epic TAG-Epic commented Jul 23, 2023

Issues:

  • No tests
  • Doesn't give you info about what part it failed at, it is only logged.

Why not just use a exception like pynacl does?

I personally prefer:

# This
if not REQUEST_VERIFIER.is_valid(...):
    return {"detail": "Go away"}, 400
    
# Over this
try:
    REQUEST_VERIFIER.verify(...):
except BaseVerificationError:
    return {"detail": "Go away"}, 400

However I am still unsure.

This is based on and superseeds #255

@TAG-Epic TAG-Epic added the type/feature A feature addition label Jul 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature A feature addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant