Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parse: Dates are changed when --fix-dates is not specified #1247

Closed
victorlin opened this issue Jun 30, 2023 · 0 comments · Fixed by #1244
Closed

parse: Dates are changed when --fix-dates is not specified #1247

victorlin opened this issue Jun 30, 2023 · 0 comments · Fixed by #1244
Assignees
@victorlin
Labels
bug

Comments

@victorlin
Copy link
Member

victorlin commented Jun 30, 2023 •
edited

Current Behavior

When --fix-dates is not specified, it acts as if --fix-dates=monthfirst is specified. Example from 96098a0:

cat >data.fasta <<~~
>SEQ1|05/01/2020
AAA
~~

augur parse \
  --sequences data.fasta \
  --output-sequences sequences.fasta \
  --output-metadata metadata.tsv \
  --fields strain date

cat metadata.tsv
#  strain	date
#  SEQ1	2020-05-01

Expected behavior

Dates should be left unchanged.

Possible solution

6b7a72c
@victorlin victorlin added the bug label Jun 30, 2023
@victorlin victorlin self-assigned this Jun 30, 2023
@victorlin victorlin mentioned this issue Jun 30, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@victorlin victorlin

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add type checking (mypy) nextstrain/augur
1 participant
@victorlin