Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slight color difference between links and non-links on /team #863

Open
victorlin opened this issue May 15, 2024 · 1 comment
Open

Slight color difference between links and non-links on /team #863

victorlin opened this issue May 15, 2024 · 1 comment
Labels
priority: low To be resolved after high and moderate priority issues

Comments

@victorlin
Copy link
Member

Noted by @tsibley in #862 (review):

people without links are shown in a slightly different shade of black. Compare Pavel to Moira:

Screenshot from 2024-05-15 16-10-34

The color difference is because (1) links here are set to a specific color and (2) the non-links don't have any color set via CSS. It seems like both our browsers default to pure black #000 in that case, so the link color #333 is slightly lighter.

@victorlin victorlin added the priority: low To be resolved after high and moderate priority issues label May 15, 2024
@victorlin
Copy link
Member Author

victorlin commented May 16, 2024

I'm guessing intent of setting link color to #333 is to match the non-link color.

The first thing to do is set the default color explicitly. global.css seems to an appropriate place to do this.

Next, those two color definitions should be synced. I don't think it's easily done with the current setup since global.css and styled components in JSX can't share a common variable (or maybe they can?). The lazy alternative is to add a comment next to each declaring the relationship.

@victorlin victorlin mentioned this issue May 16, 2024
2 tasks
@victorlin victorlin mentioned this issue May 28, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low To be resolved after high and moderate priority issues
Projects
None yet
Development

No branches or pull requests

1 participant