You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
people without links are shown in a slightly different shade of black. Compare Pavel to Moira:
The color difference is because (1) links here are set to a specific color and (2) the non-links don't have any color set via CSS. It seems like both our browsers default to pure black #000 in that case, so the link color #333 is slightly lighter.
The text was updated successfully, but these errors were encountered:
I'm guessing intent of setting link color to #333 is to match the non-link color.
The first thing to do is set the default color explicitly. global.css seems to an appropriate place to do this.
Next, those two color definitions should be synced. I don't think it's easily done with the current setup since global.css and styled components in JSX can't share a common variable (or maybe they can?). The lazy alternative is to add a comment next to each declaring the relationship.
Noted by @tsibley in #862 (review):
The color difference is because (1) links here are set to a specific color and (2) the non-links don't have any color set via CSS. It seems like both our browsers default to pure black
#000
in that case, so the link color#333
is slightly lighter.The text was updated successfully, but these errors were encountered: