Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade command add peerDep upgrade #30

Merged
merged 20 commits into from
Apr 26, 2024

Conversation

winchesHe
Copy link
Member

@winchesHe winchesHe commented Apr 17, 2024

📝 Description

1、Add peerDependencies upgrade

CleanShot.2024-04-18.at.10.05.44.mp4

2、Warn when mising

image

3、When component is latest also will check the peerDependencies

image

4、Individual component upgrade

image

✅ Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Improvement (non-breaking change which improves an existing feature)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

@jrgarciadev
Copy link
Member

@winchesHe could you please check this:
CleanShot 2024-04-22 at 16 18 24

We should only display the warning once when it is the same warning

@jrgarciadev
Copy link
Member

Same here @winchesHe
CleanShot 2024-04-22 at 17 40 05

@jrgarciadev
Copy link
Member

I believe we could add a warning message if the peerDependency like tailwindcss is installed but is not the min version

@winchesHe
Copy link
Member Author

@jrgarciadev Above issues i have resolved in this PR: #42, after i merged it, could you try again

@winchesHe
Copy link
Member Author

winchesHe commented Apr 23, 2024

@jrgarciadev After merged it is work normally

image

@winchesHe
Copy link
Member Author

winchesHe commented Apr 23, 2024

@jrgarciadev After merged it is work normally

image

Fix the output info align

List

image

Upgrade

image

@winchesHe
Copy link
Member Author

I believe we could add a warning message if the peerDependency like tailwindcss is installed but is not the min version

What about this you think

image

@jrgarciadev
Copy link
Member

Hey @winchesHe could you please adjust this as well?

Instead of showing a warning about the missing peerDepedencies we could list them inside the PeerDepedencies alert and install them

CleanShot 2024-04-24 at 10 39 15

@jrgarciadev
Copy link
Member

@winchesHe feel free to merge this PR once committed my suggestions

@jrgarciadev jrgarciadev added this to the v0.2.0 milestone Apr 25, 2024
@jrgarciadev
Copy link
Member

@winchesHe could you please fix the conflicts?

@winchesHe
Copy link
Member Author

@jrgarciadev Done

@jrgarciadev jrgarciadev merged commit d5931e8 into main Apr 26, 2024
3 checks passed
@jrgarciadev jrgarciadev deleted the feature-upgrade-add-peer-dep branch April 26, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants