Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(updated): getPackageManagerInfo #52

Merged
merged 3 commits into from
Apr 24, 2024

Conversation

ankiiisharma
Copy link
Contributor

@ankiiisharma ankiiisharma commented Apr 23, 2024

Updated getPackageManagerInfo to dynamically infer install and remove types based on package manager, ensuring type safety and flexibility.

📝 Description

✅ Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Improvement (non-breaking change which improves an existing feature)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

@winchesHe
Copy link
Member

Sure, i will take a look

@winchesHe
Copy link
Member

@ankiiisharma I have made some change, could you fix this ci error

After

image image

@ankiiisharma
Copy link
Contributor Author

@winchesHe , hey I checked this on my side . everything seems ok. can you please explain this error and why it is occurring?

@winchesHe
Copy link
Member

image

You can run git pull and npx tsc --noEmit to check it

@ankiiisharma
Copy link
Contributor Author

@winchesHe Done!, check please!

@winchesHe
Copy link
Member

@ankiiisharma thx~

@winchesHe winchesHe merged commit 10a6f56 into nextui-org:main Apr 24, 2024
3 checks passed
@ankiiisharma
Copy link
Contributor Author

@winchesHe You're Welcome😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Optimize getPackageManagerInfo function
2 participants