fix(dropdown): fixing logic gaps

nextui-org · May 8, 2024 · 4b39f0b · 4b39f0b
1 parent 0f24d08
commit 4b39f0b
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/packages/components/dropdown/src/use-dropdown.ts b/packages/components/dropdown/src/use-dropdown.ts
@@ -141,7 +141,17 @@ export function useDropdown(props: UseDropdownProps) {
       menuProps,
       closeOnSelect,
       ...mergeProps(props, {
-        onAction: () => onMenuAction(props?.closeOnSelect),
+        onAction: (key: any) => {
+          // @ts-ignore
+          const item = props?.children?.find((item) => item.key === key);
+
+          if (item?.props?.closeOnSelect === false) {
+            onMenuAction(false);
+
+            return;
+          }
+          onMenuAction(props?.closeOnSelect);
+        },
         onClose: state.close,
       }),
     } as MenuProps;

diff --git a/packages/hooks/use-aria-menu/src/use-menu-item.ts b/packages/hooks/use-aria-menu/src/use-menu-item.ts
@@ -144,7 +144,7 @@ export function useMenuItem<T>(
   let onAction = isTrigger ? () => {} : props.onAction || data.onAction;
   let router = useRouter();
   let performAction = (e: PressEvent) => {
-    if (onAction && closeOnSelect) {
+    if (onAction) {
       // @ts-ignore
       onAction(key);
     }