Skip to content

Commit

Permalink
fix(core): named exports instead of * from, use client directive adde…
Browse files Browse the repository at this point in the history
…d to main pkg
  • Loading branch information
jrgarciadev committed Apr 17, 2024
1 parent 158c2aa commit fbb211b
Show file tree
Hide file tree
Showing 8 changed files with 44 additions and 57 deletions.
1 change: 0 additions & 1 deletion packages/core/react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
"url": "https://github.com/nextui-org/nextui/issues"
},
"scripts": {
"prebuild": "node src/scripts/prebuild.js",
"build": "tsup --dts",
"postbuild": "node src/scripts/postbuild.js",
"dev": "pnpm build:fast --watch",
Expand Down
3 changes: 0 additions & 3 deletions packages/core/react/src/index.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
"use client";
// only for developments, client directive this is removed in production builds

export * from "@nextui-org/system";
export * from "@nextui-org/theme";
export * from "@nextui-org/accordion";
Expand Down
19 changes: 0 additions & 19 deletions packages/core/react/src/scripts/postbuild.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,6 @@ const appsRoutesJsonPath = path.resolve(appsConfigDir, 'routes.json'); // Apps r

const docsComponentsDir = path.resolve(rootDir, 'apps/docs/content/docs/components'); // Docs components directory path

const filePath = './src/index.ts'; // Updated file path
const backupFilePath = filePath + '.backup.ts'; // Backup file

const themeDir = path.resolve(packagesDir, 'core/theme'); // Theme directory path

const baseDocs = 'https://nextui.org/docs/components';
Expand Down Expand Up @@ -71,22 +68,6 @@ function generateComponents() {
}

function main() {
// Restore the original file from the backup
fs.copyFile(backupFilePath, filePath, (err) => {
if (err) {
return console.log(err);
}
console.log('The original file has been restored.');

// Delete the backup file
fs.unlink(backupFilePath, (err) => {
if (err) {
return console.log(err);
}
console.log('The backup file has been deleted.');
});
});

// Generate the components meta data
try {
generateComponents()
Expand Down
27 changes: 0 additions & 27 deletions packages/core/react/src/scripts/prebuild.js

This file was deleted.

1 change: 1 addition & 0 deletions packages/core/react/tsup.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,5 @@ export default defineConfig({
target: "es2019",
entry: ["src/index.ts", "!src/scripts"],
format: ["cjs", "esm"],
banner: {js: '"use client";'},
});
34 changes: 31 additions & 3 deletions packages/core/system-rsc/src/index.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,31 @@
export * from "./types";
export * from "./utils";
export * from "./extend-variants";
export type {
As,
DOMElement,
DOMElements,
CapitalizedDOMElements,
DOMAttributes,
OmitCommonProps,
RightJoinProps,
MergeWithAs,
InternalForwardRefRenderFunction,
PropsOf,
Merge,
HTMLNextUIProps,
PropGetter,
} from "./types";

export {
cn,
forwardRef,
toIterator,
mapPropsVariants,
mapPropsVariantsWithCommon,
isNextUIEl,
} from "./utils";

export {extendVariants} from "./extend-variants";
export type {
ExtendVariantProps,
ExtendVariantWithSlotsProps,
ExtendVariants,
} from "./extend-variants";
8 changes: 8 additions & 0 deletions packages/core/system/tsup.config.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
import {defineConfig} from "tsup";

export default defineConfig({
clean: true,
target: "es2019",
format: ["cjs", "esm"],
banner: {js: '"use client";'},
});
8 changes: 4 additions & 4 deletions packages/utilities/react-rsc-utils/src/index.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
export * from "./children";
export * from "./filter-dom-props";
export * from "./dom-props";
export * from "./functions";
export {getValidChildren, pickChildren} from "./children";
export {filterDOMProps} from "./filter-dom-props";
export {DOMPropNames, DOMEventNames} from "./dom-props";
export {renderFn} from "./functions";

0 comments on commit fbb211b

Please sign in to comment.