Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mobile navigation does not close when changing routes #151

Closed
mariusflorescu opened this issue Jan 22, 2022 · 0 comments · Fixed by #152
Closed

Mobile navigation does not close when changing routes #151

mariusflorescu opened this issue Jan 22, 2022 · 0 comments · Fixed by #152
Labels
🧱 Type: Refactoring

Comments

@mariusflorescu
Copy link
Contributor

mariusflorescu commented Jan 22, 2022 •
edited

Describe the bug
Whenever you are in the mobile navigation and you click on any link the navigation won't automatically close.

Steps to reproduce

  1. Be in a viewport that uses the hamburger menu
  2. You need to be on any page from the docs (expect landing)
  3. Open it
  4. Click on any link

Expected behaviour
The drawer should automatically close whenever you click on a link

Screenshots

mobile-nav.mp4

Environment / Context

  • Desktop or Mobile?: Both desktop and mobile
  • Operating System: iOS, macOS Monterey
  • Browser and version: Chrome 97, Safari
  • Device: Macbook 14'', Iphone 13
@mariusflorescu mariusflorescu mentioned this issue Jan 23, 2022
Merged
5 tasks
@jrgarciadev jrgarciadev linked a pull request Jan 23, 2022 that will close this issue
Fix #141 #152
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🧱 Type: Refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #141 mariusflorescu/nextui
2 participants
@jrgarciadev @mariusflorescu