Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #141 #152

Merged
merged 2 commits into from Jan 23, 2022
Merged

Fix #141 #152

merged 2 commits into from Jan 23, 2022

Conversation

mariusflorescu
Copy link
Contributor

@mariusflorescu mariusflorescu commented Jan 23, 2022

Docs/navbar

TASK: Mobile navigation does not close when changing routes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Only
  • Refactor

Description, Motivation and Context

Closing the drawer automatically when the route changes (if it is already expanded).

This change would be nice because when navigating on mobile is kinda annoying to keep closing manually the drawer.

To reproduce: check the issue.

Screenshots - Animations

fix.mp4

@jrgarciadev
Copy link
Member

Thanks! @mariusflorescu

@codecov-commenter
Copy link

Codecov Report

Merging #152 (5d52e69) into main (3b941f1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #152   +/-   ##
=======================================
  Coverage   76.01%   76.01%           
=======================================
  Files         140      140           
  Lines        2264     2264           
  Branches      680      680           
=======================================
  Hits         1721     1721           
  Misses        538      538           
  Partials        5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b941f1...5d52e69. Read the comment docs.

@jrgarciadev jrgarciadev merged commit a3a6c19 into nextui-org:main Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mobile navigation does not close when changing routes
3 participants