Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[LEVEL]/[COMPONENT]
TASK: New docs UI sidebar glitches (overlays the navbar) when scrolling down
Types of changes
Description, Motivation and Context
Changed from
position: sticky
toposition:fixed
. The issue was happening because the sticky positioning is treated as relative in normal context and as fixed when scrolling. Once the parent container would reach its end of height, it would just push all the content upwards.Corrected offset to match the previous position.
Renamed
Sticky
toFixed
.Screenshots - Animations
The before can be seen in Issue #149 .
After:
nav-overflow4.mp4
Please let me know if there is anything that needs to be corrected/adjusted.
PS: The video is cropped because of the file size limit.