Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #149 #153

Merged
merged 3 commits into from Jan 23, 2022
Merged

Fix #149 #153

merged 3 commits into from Jan 23, 2022

Conversation

mariusflorescu
Copy link
Contributor

@mariusflorescu mariusflorescu commented Jan 23, 2022

[LEVEL]/[COMPONENT]

TASK: New docs UI sidebar glitches (overlays the navbar) when scrolling down

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Only
  • Refactor

Description, Motivation and Context

Changed from position: sticky to position:fixed. The issue was happening because the sticky positioning is treated as relative in normal context and as fixed when scrolling. Once the parent container would reach its end of height, it would just push all the content upwards.

Corrected offset to match the previous position.

Renamed Sticky to Fixed.

Screenshots - Animations

The before can be seen in Issue #149 .

After:

nav-overflow4.mp4

Please let me know if there is anything that needs to be corrected/adjusted.

PS: The video is cropped because of the file size limit.

@jrgarciadev
Copy link
Member

Thank you! @mariusflorescu 🚀

@codecov-commenter
Copy link

Codecov Report

Merging #153 (a446514) into main (3b941f1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #153   +/-   ##
=======================================
  Coverage   76.01%   76.01%           
=======================================
  Files         140      140           
  Lines        2264     2264           
  Branches      680      680           
=======================================
  Hits         1721     1721           
  Misses        538      538           
  Partials        5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b941f1...a446514. Read the comment docs.

@jrgarciadev jrgarciadev merged commit 39c6fc6 into nextui-org:main Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New docs UI sidebar glitches (overlays the navbar) when scrolling down
3 participants