Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused framer motion features #2464

Merged

Conversation

mezotv
Copy link
Contributor

@mezotv mezotv commented Mar 7, 2024

📝 Description

Changes the motion import to the more lightweigth m component.

⛳️ Current behavior (updates)

Currently uses the motion import which loads all of the features even the ones you don't need.

🚀 New behavior

Uses the lightweight m component with only the animation features loaded into. Since thats the only thing the components use.

💣 Is this a breaking change (Yes/No):

Not a breaking change!

📝 Additional Information

Docs for this change: https://www.framer.com/motion/guide-reduce-bundle-size/

@mezotv mezotv requested a review from jrgarciadev as a code owner March 7, 2024 05:32
Copy link

changeset-bot bot commented Mar 7, 2024

🦋 Changeset detected

Latest commit: a7a03de

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 15 packages
Name Type
@nextui-org/accordion Patch
@nextui-org/modal Patch
@nextui-org/navbar Patch
@nextui-org/popover Patch
@nextui-org/ripple Patch
@nextui-org/tabs Patch
@nextui-org/tooltip Patch
@nextui-org/react Patch
@nextui-org/autocomplete Patch
@nextui-org/dropdown Patch
@nextui-org/select Patch
@nextui-org/button Patch
@nextui-org/card Patch
@nextui-org/slider Patch
@nextui-org/snippet Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Mar 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextui-docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 8, 2024 2:40pm
nextui-storybook-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 8, 2024 2:40pm

Copy link

vercel bot commented Mar 7, 2024

@mezotv is attempting to deploy a commit to the NextUI Inc Team on Vercel.

A member of the Team first needs to authorize it.

@mezotv
Copy link
Contributor Author

mezotv commented Mar 7, 2024

New pull request as the old one was force closed by github. I will add the changeset later aswell as fixing the tabs bug! @jrgarciadev

@mezotv
Copy link
Contributor Author

mezotv commented Mar 7, 2024

Hey @jrgarciadev would you mind checking my changeset. Im not sure if I did it right, got a bit confused by the way it works.

@mezotv
Copy link
Contributor Author

mezotv commented Mar 7, 2024

The tabs component should work again. It required the other domMax feature.

.changeset/warm-zoos-fry.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants