Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle RTL direction divider storybook (#2483) #2484

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

mrbadri
Copy link
Contributor

@mrbadri mrbadri commented Mar 9, 2024

Closes #2483

📝 Description

Add support for handling RTL (right-to-left) direction divider in Storybook.

⛳️ Current behavior (updates)

Currently, the divider component in Storybook does not handle RTL direction properly.

🚀 New behavior

This PR introduces fixes to handle RTL direction for the divider component in Storybook, ensuring proper alignment and functionality.

💣 Is this a breaking change (Yes/No):

No

📝 Additional Information

Summary by CodeRabbit

  • Style
    • Updated styling to support right-to-left (RTL) layout in specific components.

Copy link

changeset-bot bot commented Mar 9, 2024

⚠️ No Changeset found

Latest commit: 7e5659e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Mar 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextui-storybook-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 16, 2024 5:44am

Copy link

vercel bot commented Mar 9, 2024

@mrbadri is attempting to deploy a commit to the NextUI Inc Team on Vercel.

A member of the Team first needs to authorize it.

.changeset/fair-rabbits-decide.md Outdated Show resolved Hide resolved
Copy link
Contributor

coderabbitai bot commented Mar 16, 2024

Walkthrough

The modification in the project addresses the need for Right-to-Left (RTL) support by updating the styling of components. Specifically, it involves adding a rtl:space-x-reverse class to the <div> elements in the divider.stories.tsx file. This change ensures that elements within the divider component correctly align and display in RTL languages, enhancing usability and accessibility for a broader audience.

Changes

File(s) Change Summary
.../components/divider/stories/divider.stories.tsx Added rtl:space-x-reverse class for RTL support.

Assessment against linked issues

Objective Addressed Explanation
Bug Description: Lack of RTL Support in divider (#2483)
Reproduction Steps: Observe misalignment in RTL direction (#2483)
Expected Behavior: UI supports RTL direction correctly (#2483)
Visual Discrepancy: Illustration with screenshots in LTR and RTL (#2483) This objective relates to documentation and visual evidence, not code changes.
Environment: Ensure compatibility across OS and browsers (#2483) The change is CSS-based, which is generally browser and OS agnostic, but specific testing details are not provided.

🐰✨
A hop, a skip, in code we dip,
To fix the RTL, so it won't flip.
With space-x-reverse, we set the stage,
For texts to flow, from page to page.
🌐↔️
In every script, let's make it right,
For every read, from right to left, a delightful sight.
🎉🐇

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between e67b3af and 7e5659e.
Files selected for processing (1)
  • packages/components/divider/stories/divider.stories.tsx (1 hunks)

@jrgarciadev jrgarciadev merged commit 9873c6f into nextui-org:main Apr 16, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - Lack of RTL Support in divider
2 participants