Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): add RTL support to the select component (#2042) #2485

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

mrbadri
Copy link
Contributor

@mrbadri mrbadri commented Mar 9, 2024

Closes #2042

📝 Description

Add RTL support to the select component.

⛳️ Current behavior (updates)

The select component currently lacks support for right-to-left (RTL) direction.

🚀 New behavior

This PR addresses the RTL support issue in the select component, ensuring correct rendering in RTL environments.

💣 Is this a breaking change (Yes/No):

📝 Additional Information

Copy link

changeset-bot bot commented Mar 9, 2024

🦋 Changeset detected

Latest commit: bc1de6c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@nextui-org/select Patch
@nextui-org/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Mar 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextui-storybook-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 9, 2024 0:55am

Copy link

vercel bot commented Mar 9, 2024

@mrbadri is attempting to deploy a commit to the NextUI Inc Team on Vercel.

A member of the Team first needs to authorize it.

@jrgarciadev
Copy link
Member

@mrbadri could you make the Listbox items to be RTL as well?

CleanShot 2024-03-15 at 22 47 32

@jrgarciadev jrgarciadev merged commit aab1f19 into nextui-org:main Apr 16, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RTL support for select and labels
2 participants