fix(skeleton): missing disableAnimation behaviour in skeleton #2538
Conversation
🦋 Changeset detectedLatest commit: d94cd25 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@wingkwong is attempting to deploy a commit to the NextUI Inc Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThis update introduces dependencies on Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 1
Configuration used: .coderabbit.yaml
Files selected for processing (2)
- .changeset/eleven-maps-admire.md (1 hunks)
- packages/core/theme/src/components/skeleton.ts (1 hunks)
Additional comments: 1
packages/core/theme/src/components/skeleton.ts (1)
- 59-64: > 📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [1-48]
The changes to the skeleton component, including the removal of the
defaultVariantsproperty, appear to align with the objective of fixing thedisableAnimationbehavior. However, it would be beneficial to add comments explaining how thedisableAnimationproperty is now handled, especially for future maintainability and clarity for other developers.
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: .coderabbit.yaml
Files selected for processing (1)
- .changeset/eleven-maps-admire.md (1 hunks)
Additional comments: 2
.changeset/eleven-maps-admire.md (2)
- 1-4: The metadata section correctly identifies the affected packages (
@nextui-org/skeletonand@nextui-org/theme) and the type of version bump (patch). This is appropriate for the changes described, which address a bug fix.- 6-6: The description clearly outlines the fix for the missing
disableAnimationbehavior in theSkeletoncomponent. The termdisableAnimationis correctly used here, referring to a specific property in the context of the component's API, and should not be altered.
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: .coderabbit.yaml
Files selected for processing (2)
- .changeset/eleven-maps-admire.md (1 hunks)
- packages/core/theme/src/components/skeleton.ts (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- packages/core/theme/src/components/skeleton.ts
Additional comments: 1
.changeset/eleven-maps-admire.md (1)
- 1-6: The changeset document clearly outlines the patch updates for
@nextui-org/skeletonand@nextui-org/themepackages and provides a concise description of the fix related to thedisableAnimationbehavior in the skeleton component. Everything looks good here.
Closes #2537
📝 Description
the default variants wont't let custom variants to override
⛳️ Current behavior (updates)
🚀 New behavior
disableAnimation = truepr-2538-demo.webm
💣 Is this a breaking change (Yes/No):
📝 Additional Information
Summary by CodeRabbit
disableAnimationbehavior in the skeleton component.defaultVariantsproperty from the skeleton component for optimization.