-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(progress): turn twMerge true to fix custom styling #2668
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: dc270de The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Someone is attempting to deploy a commit to the NextUI Inc Team on Vercel. A member of the Team first needs to authorize it. |
Warning Rate Limit Exceeded@wingkwong has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 31 minutes and 6 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe recent update enhances the customization capabilities of the Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Status
Configuration used: .coderabbit.yaml
Files selected for processing (3)
- .changeset/short-trainers-dance.md (1 hunks)
- packages/components/progress/stories/progress.stories.tsx (1 hunks)
- packages/core/theme/src/components/progress.ts (1 hunks)
Additional comments not posted (3)
.changeset/short-trainers-dance.md (1)
1-6
: The changeset description is clear and accurately reflects the changes made to the@nextui-org/progress
and@nextui-org/theme
packages. The spelling oftwMerge
is correct in this context.packages/components/progress/stories/progress.stories.tsx (1)
126-136
: The addition of theCustomSlots
story effectively demonstrates the new customization capabilities withtwMerge
set to true. This is a valuable example for users looking to customize the Progress component.packages/core/theme/src/components/progress.ts (1)
136-136
: Changing thetwMerge
property fromfalse
totrue
correctly implements the intended functionality to enable customization of the Progress component. This change is described as non-breaking and aligns with the PR objectives.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Status
Configuration used: .coderabbit.yaml
Files selected for processing (1)
- .changeset/short-trainers-dance.md (1 hunks)
Additional comments not posted (2)
.changeset/short-trainers-dance.md (2)
2-3
: The versioning strategy usingpatch
for both "@nextui-org/progress" and "@nextui-org/theme" is appropriate, considering the changes are non-breaking and focused on enhancing customization capabilities.
6-6
: Consider refining the description to provide more context about the change, for example: "Enables custom slot styling in the Progress component by settingtwMerge
totrue
, allowing for more flexible class name customization."
Hi! Just checking in : everything okay with the code in that PR ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Closes #2153
📝 Description
⛳️ Current behavior (updates)
🚀 New behavior
💣 Is this a breaking change (Yes/No): No
📝 Additional Information
Summary by CodeRabbit
CustomSlots
for more flexible customization in progress components.