Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add peerDep files in components.json and update theme peerDep #2689

Merged
merged 1 commit into from
Apr 14, 2024

Conversation

winchesHe
Copy link
Member

@winchesHe winchesHe commented Apr 12, 2024

Closes #

📝 Description

Add a brief description

  • Add peer dependencies in @nextui-org/theme

  • Add peer dependencies files in components.json

image

⛳️ Current behavior (updates)

Please describe the current behavior that you are modifying

🚀 New behavior

Please describe the behavior or changes this PR adds

💣 Is this a breaking change (Yes/No):

📝 Additional Information

Summary by CodeRabbit

  • New Features
    • Integrated TailwindCSS across all components for enhanced styling capabilities.
  • Chores
    • Updated build scripts to recognize new peer dependencies.

Copy link

changeset-bot bot commented Apr 12, 2024

⚠️ No Changeset found

Latest commit: 52acac4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Apr 12, 2024

@winchesHe is attempting to deploy a commit to the NextUI Inc Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Apr 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextui-storybook-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 13, 2024 1:52am

Copy link
Contributor

coderabbitai bot commented Apr 12, 2024

Walkthrough

The recent updates across various component packages in the software project involve adding "tailwindcss" version ">=3.4" as either a dependency or a peer dependency. This consistent change signifies a move towards incorporating Tailwind CSS for styling purposes. Additionally, certain files have been modified to include peerDependencies in the component information objects post-build.

Changes

Files Change Summary
.../accordion/package.json, .../autocomplete/package.json, .../avatar/package.json, .../breadcrumbs/package.json, .../button/package.json, .../card/package.json, .../checkbox/package.json, .../chip/package.json, .../dropdown/package.json, .../image/package.json, .../input/package.json, .../link/package.json, .../listbox/package.json, .../menu/package.json, .../modal/package.json, .../navbar/package.json, .../pagination/package.json, .../popover/package.json, .../progress/package.json, .../radio/package.json, .../ripple/package.json, .../scroll-shadow/package.json, .../slider/package.json, .../snippet/package.json, .../switch/package.json, .../table/package.json, .../tabs/package.json, .../tooltip/package.json, .../user/package.json Added "tailwindcss": ">=3.4" as a dependency
.../badge/package.json, .../code/package.json, .../divider/package.json, .../kbd/package.json, .../skeleton/package.json, .../spacer/package.json, .../spinner/package.json Added "tailwindcss": ">=3.4" as a peer dependency
.../select/package.json Added "tailwindcss" as a dependency; updated versions for "react-dom", "framer-motion", "@nextui-org/theme", "@nextui-org/system"
.../core/react/package.json, .../core/react/src/scripts/postbuild.js Added "tailwindcss": ">=3.4" as a peer dependency; updated postbuild.js to include peerDependencies in component information object

Recent Review Details

Configuration used: .coderabbit.yaml

Commits Files that changed from the base of the PR and between ebab108 and 52acac4.
Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !pnpm-lock.yaml
Files selected for processing (2)
  • packages/core/react/src/scripts/postbuild.js (3 hunks)
  • packages/core/theme/package.json (2 hunks)
Files skipped from review as they are similar to previous changes (1)
  • packages/core/react/src/scripts/postbuild.js
Additional comments not posted (2)
packages/core/theme/package.json (2)

61-61: The update to specify tailwindcss version >=3.4.0 in peerDependencies is appropriate and aligns with the PR's objectives to ensure compatibility with newer versions.


71-71: The specification of tailwindcss version ^3.4.0 in devDependencies is consistent with the peer dependency version and ensures that the development environment uses a compatible version.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@winchesHe winchesHe changed the title feat: add peer dependencies in each components feat: add peerDep files in components.json and update theme peerDep Apr 13, 2024
@jrgarciadev jrgarciadev merged commit 09504cd into nextui-org:main Apr 14, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants