Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): hsl rounding issue #2702

Merged
merged 2 commits into from Apr 13, 2024
Merged

fix(core): hsl rounding issue #2702

merged 2 commits into from Apr 13, 2024

Conversation

wingkwong
Copy link
Member

@wingkwong wingkwong commented Apr 13, 2024

Closes #2697

📝 Description

Currently the HSL values got rounded.

#787865:

Color(colorValue).hsl() {
  model: 'hsl',
  color: [ 60, 8.597285067873305, 43.333333333333336 ],
  valpha: 1
}

It will become color: [ 60, 9, 43 ]. In this case, the color will be slightly changed.

⛳️ Current behavior (updates)

Please describe the current behavior that you are modifying

🚀 New behavior

Please describe the behavior or changes this PR adds

💣 Is this a breaking change (Yes/No):

📝 Additional Information

Summary by CodeRabbit

  • Bug Fixes
    • Fixed an HSL color rounding issue in the theme settings to ensure accurate color representation.

Copy link

linear bot commented Apr 13, 2024

Copy link

changeset-bot bot commented Apr 13, 2024

🦋 Changeset detected

Latest commit: 10cef6c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@nextui-org/theme Patch
@nextui-org/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

coderabbitai bot commented Apr 13, 2024

Walkthrough

The recent changes involve a patch to address an HSL rounding issue in the "@nextui-org/theme" package, specifically within the plugin.ts file. The modifications refine how color values are parsed and stored, aiming to ensure that the colors set by users in configuration files are rendered accurately on the web interface.

Changes

File Path Change Summary
.changeset/real-parrots-act.md Introduced a patch for HSL rounding issue
packages/core/theme/src/plugin.ts Modified logic for color parsing and caching

Assessment against linked issues

Objective Addressed Explanation
Ensure exact color rendering as configured [#2697]
Fix HSL rounding issue to maintain color integrity

The changes effectively address the primary concern of issue #2697, ensuring that personalized colors are rendered exactly as configured, which was previously affected by a minor discrepancy in HSL rounding.


Recent Review Details

Configuration used: .coderabbit.yaml

Commits Files that changed from the base of the PR and between 85b422d and 10cef6c.
Files selected for processing (1)
  • .changeset/real-parrots-act.md (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • .changeset/real-parrots-act.md

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

vercel bot commented Apr 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextui-docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 13, 2024 2:18pm
nextui-storybook-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 13, 2024 2:18pm

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

.changeset/real-parrots-act.md Outdated Show resolved Hide resolved
@jrgarciadev
Copy link
Member

@wingkwong could you update the description with the round(2) result?

@jrgarciadev jrgarciadev merged commit 2829d4a into main Apr 13, 2024
8 checks passed
@jrgarciadev jrgarciadev deleted the fix/eng-628 branch April 13, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - Personalized color gets slightly changed
2 participants