fix(table): add empty content only when table size is 0 #2742

[ShrinidhiUpadhyaya]

Closes #2742

📝 Description

When using the Table component and isLoading is set to true on the TableBody and there are already rows present, empty content is being added to the end of the table

⛳️ Current behavior (updates)

🚀 New behavior

💣 Is this a breaking change (Yes/No):

📝 Additional Information

Summary by CodeRabbit

• New Features
  • Enhanced the table display to conditionally show a specific element when there are no items in the collection.
  • Fixed the issue of adding empty content at the bottom of the table when rows are present.

[changeset-bot]

🦋 Changeset detected

Latest commit: 0a445fa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@nextui-org/table	Patch
@nextui-org/react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

Someone is attempting to deploy a commit to the NextUI Inc Team on Vercel.

A member of the Team first needs to authorize it.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nextui-docs-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 17, 2024 1:54pm
nextui-storybook-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 17, 2024 1:54pm

[coderabbitai]

Walkthrough

The update to the TableBody component now includes a conditional rendering to prevent the display of an empty <td> element when the collection size is zero. This change is aimed at addressing the issue where an empty row was appended to a table when the isLoading property was set to true.

Changes

File Path	Change Summary
packages/components/table/src/table-body.tsx	Added check to conditionally render <td> when collection.size === 0.
.changeset/lazy-pears-turn.md	Introduced a patch for the "@nextui-org/table" package to fix the issue of adding empty content at the bottom of the table when rows are present.

Assessment against linked issues

Objective	Addressed	Explanation
Prevent empty row addition when isLoading=true [#2742]	✅
Ensure no UI changes when collection is not empty [#2742]	❓	The modification specifically targets empty collections; unclear effects on non-empty states.

This assessment indicates that the main issue of the empty row being added when isLoading is set has been addressed, though the behavior on non-empty collections needs clarification.

---

Recent Review Details

Configuration used: .coderabbit.yaml

Commits

Files that changed from the base of the PR and between 7d91869 and 0a445fa.

Files selected for processing (1)

• .changeset/lazy-pears-turn.md (1 hunks)

Additional comments not posted (1)

.changeset/lazy-pears-turn.md (1)

1-5: The changeset is well-formed and clearly describes the patch for the "@nextui-org/table" package, linking it appropriately to the GitHub issue #2742.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[jrgarciadev]

Thank you! @ShrinidhiUpadhyaya