Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(calendar): maximum update depth exceeded #2861

Merged
merged 1 commit into from Apr 24, 2024
Merged

Conversation

jrgarciadev
Copy link
Member

@jrgarciadev jrgarciadev commented Apr 24, 2024

…dar & RangeCalendar

Closes #2820 #2857

📝 Description

This PR fixes the "Maximum update depth exceeded" error when hovering quickly over the dates on Calendar & RangeCalendar.

⛳️ Current behaviour (updates)

image

🚀 New behavior

Needless self-state removed so this error is gone.

💣 Is this a breaking change (Yes/No): No

📝 Additional Information

Summary by CodeRabbit

  • Bug Fixes

    • Fixed an issue in Calendar & RangeCalendar that caused maximum update depth exceeded errors when hovering over dates.
  • Refactor

    • Simplified state management in the CalendarMonth component for enhanced clarity and reduced complexity.

Copy link

changeset-bot bot commented Apr 24, 2024

🦋 Changeset detected

Latest commit: f4f8d19

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@nextui-org/calendar Patch
@nextui-org/date-picker Patch
@nextui-org/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

coderabbitai bot commented Apr 24, 2024

Walkthrough

The recent updates focus on enhancing the performance and simplicity of the Calendar components. A significant patch fixes the "maximum update depth exceeded" error on Calendar & RangeCalendar components. Additionally, the CalendarMonth component has been streamlined by removing its self-controlled state and relying directly on the context for state management, thereby improving clarity and reducing complexity.

Changes

File Path Change Summary
.changeset/tasty-keys-cover.md Introduces a patch for fixing issues related to maximum update depth exceeded on Calendar & RangeCalendar when hovering the dates.
.../calendar/src/calendar-month.tsx Simplified state management by removing the self-controlled state and related useEffect, now using state directly from the context.

Recent Review Details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits Files that changed from the base of the PR and between 1ba2d02 and f4f8d19.
Files selected for processing (2)
  • .changeset/tasty-keys-cover.md (1 hunks)
  • packages/components/calendar/src/calendar-month.tsx (2 hunks)
Files skipped from review due to trivial changes (1)
  • packages/components/calendar/src/calendar-month.tsx
Additional Context Used
LanguageTool (1)
.changeset/tasty-keys-cover.md (1)

Near line 5: Possible spelling mistake found.
Context: ...mum update depth exceeded on Calendar & RangeCalendar when hovering the dates.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

vercel bot commented Apr 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextui-docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2024 7:14pm
nextui-storybook-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2024 7:14pm

@jrgarciadev jrgarciadev changed the title fix(calendar): fix #2820 #2857 maximum update depth exceeded on Calen… fix(calendar): maximum update depth exceeded Apr 24, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

"@nextui-org/calendar": patch
---

Fix #2820 #2857 Maximum update depth exceeded on Calendar & RangeCalendar when hovering the dates.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct the spelling mistake in the issue description.

- Fix #2820 #2857 Maximum update depth exceeded on Calendar & RangeCalendar when hovering the dates.
+ Fix #2820 #2857: Maximum update depth exceeded in Calendar & RangeCalendar when hovering over the dates.

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
Fix #2820 #2857 Maximum update depth exceeded on Calendar & RangeCalendar when hovering the dates.
Fix #2820 #2857: Maximum update depth exceeded in Calendar & RangeCalendar when hovering over the dates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - Date Range Picker Causes "Maximum update depth exceeded" error when hovering quickly over the dates
2 participants