New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(calendar): maximum update depth exceeded #2861
Conversation
…dar & RangeCalendar
🦋 Changeset detectedLatest commit: f4f8d19 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughThe recent updates focus on enhancing the performance and simplicity of the Calendar components. A significant patch fixes the "maximum update depth exceeded" error on Calendar & RangeCalendar components. Additionally, the Changes
Recent Review DetailsConfiguration used: .coderabbit.yaml Files selected for processing (2)
Files skipped from review due to trivial changes (1)
Additional Context UsedLanguageTool (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
"@nextui-org/calendar": patch | ||
--- | ||
|
||
Fix #2820 #2857 Maximum update depth exceeded on Calendar & RangeCalendar when hovering the dates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct the spelling mistake in the issue description.
- Fix #2820 #2857 Maximum update depth exceeded on Calendar & RangeCalendar when hovering the dates.
+ Fix #2820 #2857: Maximum update depth exceeded in Calendar & RangeCalendar when hovering over the dates.
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
Fix #2820 #2857 Maximum update depth exceeded on Calendar & RangeCalendar when hovering the dates. | |
Fix #2820 #2857: Maximum update depth exceeded in Calendar & RangeCalendar when hovering over the dates. |
…dar & RangeCalendar
Closes #2820 #2857
📝 Description
This PR fixes the "Maximum update depth exceeded" error when hovering quickly over the dates on Calendar & RangeCalendar.
⛳️ Current behaviour (updates)
🚀 New behavior
Needless
self-state
removed so this error is gone.💣 Is this a breaking change (Yes/No): No
📝 Additional Information
Summary by CodeRabbit
Bug Fixes
Refactor
CalendarMonth
component for enhanced clarity and reduced complexity.