fix(theme): add pointer-events-none to skeleton base #2972
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 72ad5f9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughThis update introduces a modification to the Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (2)
- .changeset/slow-mice-act.md (1 hunks)
- packages/core/theme/src/components/skeleton.ts (1 hunks)
Files skipped from review due to trivial changes (1)
- .changeset/slow-mice-act.md
Additional comments not posted (1)
packages/core/theme/src/components/skeleton.ts (1)
22-22: Addition ofpointer-events-nonecorrectly implements the requested feature to prevent interaction with elements covered by the Skeleton component.Verification successful
The addition of the
pointer-events-noneclass in theskeletonfunction withinpackages/core/theme/src/components/skeleton.tscorrectly implements the requested feature to prevent interaction with elements covered by the Skeleton component. This confirms that the implementation aligns with the intended functionality as described in the review comment.
- File:
packages/core/theme/src/components/skeleton.ts- Location:
baseslot of theskeletonfunctionScripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the correct application of `pointer-events-none` in the Skeleton component. # Test: Search for the usage of the Skeleton component in the project to ensure it behaves as expected. rg --type css 'skeleton'Length of output: 24
Script:
#!/bin/bash # Description: Search for the usage of the Skeleton component in JavaScript or TypeScript files to verify the application of `pointer-events-none`. # Search for references to the Skeleton component in JavaScript or TypeScript files. rg --type js,ts 'Skeleton' --files-with-matchesLength of output: 77
Script:
#!/bin/bash # Description: Correctly search for the usage of the Skeleton component in JavaScript and TypeScript files to verify the application of `pointer-events-none`. # Search for references to the Skeleton component in JavaScript files. rg --type js 'Skeleton' --files-with-matches # Search for references to the Skeleton component in TypeScript files. rg --type ts 'Skeleton' --files-with-matchesLength of output: 816
Script:
#!/bin/bash # Description: Inspect the implementation of the Skeleton component to verify the application of `pointer-events-none`. # Display the contents of the Skeleton component implementation files. cat packages/components/skeleton/src/skeleton.tsx cat packages/components/skeleton/src/use-skeleton.tsLength of output: 2716
Script:
#!/bin/bash # Description: Inspect the theme configuration or function where `pointer-events-none` might be defined or applied. # Display the contents of the theme configuration or relevant function for the Skeleton component. cat packages/core/theme/src/components/skeleton.tsLength of output: 1927
Closes #1714
📝 Description
as titled
⛳️ Current behavior (updates)
if you put a button with onPress inside skeleton, the onPress can be triggered.
🚀 New behavior
The content should be hidden and events should not be triggered
💣 Is this a breaking change (Yes/No):
📝 Additional Information
Summary by CodeRabbit
pointer-events-nonestyle to the skeleton component, ensuring it does not interfere with user interactions.