-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: framer motion #3361
refactor: framer motion #3361
Conversation
π¦ Changeset detectedLatest commit: 8b4b115 The changes in this PR will be included in the next version bump. This PR includes changesets to release 52 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Base branches to auto review (5)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Tip Early access features: enabledWe are currently testing the following features in early access:
Note:
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
* chore(deps): update framer-motion version in peerDependencies * chore(deps): sync framer-motion version across packages * chore(deps): pnpm-lock.yaml * feat(changeset): add changeset
Closes #3340
π Description
usedomAnimation
instead ofdomMax
in Tabs componentAffected components:
Unchanged components:
For tabs component, we need to use
domMax
to achieve the shifting when switching between tabs. We cannot use dynamic load here as it fails sometimes, e.g. the animation will be gone sometimes. probably a bug in framer-motion.β³οΈ Current behavior (updates)
vite-template + 8 above-mentioned components
π New behavior
vite-template + 8 above-mentioned components
/doc
includes the above-mentioned 8 components that use LazyMotion.π£ Is this a breaking change (Yes/No):
No
π Additional Information