-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Switch Animation In Safari #553
Conversation
@jrgarciadev I apply option2 so we can maintain existing interactions with no lag or shaking bug |
Hey @TroyTae thank you so much, I'll check this out as soon as possible 🙏🏻 |
Codecov Report
@@ Coverage Diff @@
## main #553 +/- ##
=======================================
Coverage 74.82% 74.82%
=======================================
Files 200 200
Lines 3098 3098
Branches 956 956
=======================================
Hits 2318 2318
Misses 765 765
Partials 15 15
Continue to review full report at Codecov.
|
Hey @TroyTae 🙌🏼, could you please fix the conflicts and format the code with the new eslint rules? |
@jrgarciadev I finished to fix conflicts and apply new eslint rules! |
Hey @TroyTae thank you, I going to check it out, regarding which branch you should use before sending a PR, it depends on the change, if your changes don't include |
Hey, @TroyTae sorry, I updated the |
@jrgarciadev Done! Thank you for updating :) |
Hey @TroyTae could you please remove the Here's the issue: |
@jrgarciadev Thank you I just finished to fix it 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much @TroyTae 🙏🏻
Closes #525
📝 Description
⛳️ Current behavior (updates)
Switch circle is shaking when we off switch
🚀 New behavior
💣 Is this a breaking change (Yes/No): No
📝 Additional Information
Shaking bug is solved but there is some lag because width animation is very heavy.It's fine at Chrome but it seems Safari cannot process this kind of animation well.
Option1:So I would like to suggest to remove width animation in active state.
Option2:
Or if you want to maintain current interaction.
We can change prop
checked
to css&:checked + .circle
.