-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(react-container): add forwardRef #567
Conversation
96a5393
to
3fd53c6
Compare
I made the change. Out of curiosity, could you please explain why you prefer this way, even tho you do not give any use to the ref created inside the component? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, @danielsimao 馃檹馃徎, I prefer the way of using the ref through the useDomRef
because it customises the instance value that is exposed to parent components, it allows us to have better control of the internal ref
, here's the official docs:
https://reactjs.org/docs/hooks-reference.html#useimperativehandle
Could you please fix the conflicts? @danielsimao 馃檹馃徎 |
3fd53c6
to
9732087
Compare
9732087
to
7ab40ed
Compare
@jrgarciadev done |
Thanks a lot! @danielsimao 馃殌 |
1 similar comment
Thanks a lot! @danielsimao 馃殌 |
Closes #566
馃摑 Description
Allow passing
ref
to Container鉀筹笍 Current behavior (updates)
Doesn't allow to pass
ref
.馃殌 New behavior
Allows passing
ref
.馃挘 Is this a breaking change (Yes/No):
No