Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(doc): remove unimplemented Dropdown API #587

Merged
merged 1 commit into from
Jul 1, 2022

Conversation

imchell
Copy link
Contributor

@imchell imchell commented Jun 29, 2022

Closes #585

馃摑 Description

onAction & onClose are currently not Dropdown.Item props and may lead to confusion.

馃挘 Is this a breaking change (Yes/No): No

@imchell imchell changed the title romove unimplemented apis fix(doc): romove unimplemented Dropdown API Jun 29, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #587 (d86753c) into main (2eb31e5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #587   +/-   ##
=======================================
  Coverage   74.82%   74.82%           
=======================================
  Files         200      200           
  Lines        3098     3098           
  Branches      956      956           
=======================================
  Hits         2318     2318           
  Misses        765      765           
  Partials       15       15           

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 2eb31e5...d86753c. Read the comment docs.

@danielsimao
Copy link
Contributor

@imchell commit and PR title typo

@imchell imchell changed the title fix(doc): romove unimplemented Dropdown API fix(doc): remove unimplemented Dropdown API Jun 29, 2022
@imchell
Copy link
Contributor Author

imchell commented Jun 29, 2022

@danielsimao Thanks!

@jrgarciadev
Copy link
Member

Thanks a lot! @imchell 馃檹馃徎

@jrgarciadev jrgarciadev merged commit 0f3b3f2 into nextui-org:main Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - Components/Dropdown
4 participants