Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-dropdown): zIndex for focused dropdown item #595

Merged

Conversation

precious-void
Copy link
Contributor

Closes #517

📝 Description

Added zIndex for focused state to make an item focused with keyboard be always above hover state.

⛳️ Current behavior (updates)

image

🚀 New behavior

Screen Shot 2022-07-03 at 1 15 19

💣 Is this a breaking change (Yes/No)

No

@jrgarciadev jrgarciadev added this to the 🚀 v1.0.0-beta.10 milestone Jul 3, 2022
@jrgarciadev jrgarciadev changed the base branch from main to next July 3, 2022 12:43
@jrgarciadev
Copy link
Member

Hey @shtelzerartem thanks a lot, could you please change the value of the zIndex by : $1?, in order to use the NextUI Design system z-index values https://nextui.org/docs/theme/default-theme#z-index-values, could you also fix the conflicts?

@precious-void
Copy link
Contributor Author

Hey @jrgarciadev fixed it in the latest commits!

@jrgarciadev jrgarciadev merged commit 2fbc734 into nextui-org:next Jul 3, 2022
@jrgarciadev jrgarciadev mentioned this pull request Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] - Components/Dropdown
2 participants