Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update getting-started.mdx - replace regex #34

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

pdolezal0
Copy link
Contributor

Hey, I'm experiencing heavy CPU usage with the current RegEx so I found better, that actually doesn't spin my CPU into clouds.

context:
tailwindlabs/tailwindcss-intellisense#893 (comment)

tailwindlabs/tailwindcss-intellisense#973

tailwindlabs/tailwindcss-intellisense#963

Hey, I'm experiencing heavy CPU usage with the current RegEx so I found better, that actually doesn't spin my CPU into clouds.

context:
tailwindlabs/tailwindcss-intellisense#893 (comment)

tailwindlabs/tailwindcss-intellisense#973

tailwindlabs/tailwindcss-intellisense#963
Copy link

vercel bot commented Jun 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tailwind-variants-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2024 7:43am

@thecrypticace
Copy link

Hi! Jordan from the Tailwind Labs team here.

Here's another one for some context: tailwindlabs/tailwindcss-intellisense#897 (comment)

I did a small bit of research on the current variants regex (or more directly, on a smaller version of it) a while back and my results are there — but tl;dr nested *s can be super slow in some cases.

I meant to open an issue about it here and apparently never got around to it. Sorry!

@ViktorPontinen
Copy link

This new pattern actually fixed issue for me where whole Intellisense would hang. Seems like this pattern is more performant. I'm no regex guru, but can at least confirm that it works.
See discussion here: tailwindlabs/tailwindcss#11532

@mskelton mskelton merged commit 1908965 into nextui-org:main Jun 18, 2024
2 checks passed
@pdolezal0 pdolezal0 deleted the patch-1 branch June 19, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants