Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: variant as array when extending #123

Merged
merged 1 commit into from
Oct 30, 2023
Merged

fix: variant as array when extending #123

merged 1 commit into from
Oct 30, 2023

Conversation

thefalked
Copy link
Contributor

Description

Fixes the mergeObjects function that was only allowing string for variants.

Additional context

When using the extend property, it's used the function mergeObjects but it doesn't handle array inputs only string.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Follow the Style Guide.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).

mskelton
mskelton approved these changes Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@mskelton mskelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@mskelton mskelton merged commit 1080de7 into nextui-org:main Oct 30, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mskelton mskelton mskelton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thefalked @mskelton