Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: align class value with tailwind-merge #89

Merged
merged 1 commit into from
Sep 6, 2023
Merged

fix: align class value with tailwind-merge #89

merged 1 commit into from
Sep 6, 2023

Conversation

marbemac
Copy link
Contributor

@marbemac marbemac commented Aug 9, 2023

Description

This PR aligns the ClassValue type with with corresponding type from tailwind-merge. In particular, the old type was missing 0 and false as possible values. This makes it difficult to use tailwind-merge + tailwind-variants together since the base class typing is different between the two projects.


What is the purpose of this pull request?

  • Bug fix (kind of?)
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Follow the Style Guide.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).

Copy link
Collaborator

@mskelton mskelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mskelton mskelton merged commit ae40db4 into nextui-org:main Sep 6, 2023
4 checks passed
@marbemac
Copy link
Contributor Author

Hi @mskelton - any chance ya'll are thinking about cutting a release soon? Thanks!

@mskelton
Copy link
Collaborator

@marbemac I don't have publish permissions, going to defer to @jrgarciadev for that request.

@marbemac
Copy link
Contributor Author

@jrgarciadev sorry to bother again, but any chance ya'll could cut a release 🙏?

@jrgarciadev
Copy link
Member

Hey @marbemac yes for sure I plan to release tailwind-variants new version as soon as we end testing it on NextUI, by the end of this week

@marbemac
Copy link
Contributor Author

🎉 thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants