Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal widget #194

Open
8 of 10 tasks
Tracked by #130
, #145 ,  #202
...
nexushoratio opened this issue Nov 8, 2023 · 2 comments
Open
8 of 10 tasks
Tracked by #130
, #145 ,  #202
...

Modal widget #194

nexushoratio opened this issue Nov 8, 2023 · 2 comments
Labels
enhancement New feature or request library For libraries

Comments

@nexushoratio
Copy link
Owner

nexushoratio commented Nov 8, 2023 •
edited

Likely just a renaming of the Info widget, though with more intent.

  • Widget enhancements #190
  • widget adapters for common types #191
  • ARIA roles to keep in mind
    • Modal
    • Base implementation
    • aria-labelledby (element id) OR aria-label (text)
    • aria-describedby (element id) (via documentation)
    • trap TAB Modal widget #194 (comment)
    • Should the API require header with label stuff and a close button, or let that come with later content? Maybe fail build() and/or show() if not present?
    • Address this: If a variable holding a widget is set to a new value, the previous widget should be explicitly destroyed.
@nexushoratio nexushoratio added enhancement New feature or request library For libraries labels Nov 8, 2023
@nexushoratio nexushoratio self-assigned this Nov 19, 2023
@nexushoratio nexushoratio mentioned this issue Nov 19, 2023
Open
3 tasks
@nexushoratio
Copy link
Owner Author

nexushoratio commented Nov 19, 2023 •
edited

From <dialog> on MDN:

The <dialog> element is exposed by browsers in a manner similar to custom dialogs that use the ARIA role="dialog" attribute. elements invoked by the showModal() method implicitly have aria-modal="true",

nexushoratio pushed a commit that referenced this issue Nov 22, 2023
Initial implementation of Modal.
6bf1a58 
Issue #194.

␄
nexushoratio pushed a commit that referenced this issue Nov 23, 2023
Implement helper methods for adding HTML attributes to a Widget.
19a9df2 
Issue #194.

␄
nexushoratio pushed a commit that referenced this issue Nov 24, 2023
Implement a generic verification framework for Widgets.
304f910 
Currently automatically called after build() and before show() and users may
call explicitly.

Issue #194.

␄
nexushoratio pushed a commit that referenced this issue Nov 25, 2023
Verify Modal has exactly one of the mandatory ARIA attributes.
8d92000 
Issue #194.

␄
nexushoratio pushed a commit that referenced this issue Nov 26, 2023
Briefly document aria-describedby in Modal.
34b82cc 
Issue #194.

␄
@nexushoratio
Copy link
Owner Author

Not sure how to capture the TAB key. Mostly because of wanting to make sure it is compatible with VM.shortcut

Putting this on the back burner for now.

@nexushoratio nexushoratio removed their assignment Nov 26, 2023
@nexushoratio nexushoratio self-assigned this Jan 9, 2024
nexushoratio pushed a commit that referenced this issue Jan 14, 2024
Simplify Modal by always having content present.
af48640 
Similar to what we did for `Layout`.

Issue #194.

␄
nexushoratio pushed a commit that referenced this issue Jan 17, 2024
Be sure to destroy previous content when setting new.
feccf21 
Issue #194.

␄
@nexushoratio nexushoratio removed their assignment Jan 18, 2024
nexushoratio pushed a commit that referenced this issue Jan 29, 2024
Mark Layout and Modal as works in progress.
48d6a0a 
Issues #192, #194.
This was referenced Feb 23, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request library For libraries
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nexushoratio