Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add standard methods of DependencyProviders #15

Merged
merged 1 commit into from Jul 9, 2022

Conversation

db-mobile
Copy link
Collaborator

Changes

Breaking changes

  • n/a

New / changed / removed

  • n/a

Improvements

  • n/a
Code Review

Code Review

What's part of a code review?

Readability & Maintainability

  • Code is not more complex than needed
  • Clear names are used (good naming practices)
  • Test coverage is sufficient and tests are well designed
  • Code has proper error handling

Documentation

  • Code is properly documented

Security & Performance

  • No obvious security flaws
  • No notable performance decrease

@db-mobile db-mobile changed the title Add standar methods of DependencyProviders Add standard methods of DependencyProviders Jul 8, 2022
@patrickjaja patrickjaja merged commit ebfe396 into main Jul 9, 2022
@pwnyprod pwnyprod deleted the dependency-provider-methods branch July 14, 2022 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants