New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.6 #18

Merged

patrickjaja merged 2 commits into main from refactor

Jul 9, 2022

Contributor

patrickjaja commented Jul 9, 2022

Changes

Breaking changes

n/a

New / changed / removed

n/a

Improvements

n/a

Code Review

Code Review

What's part of a code review?

Readability & Maintainability

Code is not more complex than needed
Clear names are used (good naming practices)
Test coverage is sufficient and tests are well designed
Code has proper error handling

Documentation

Code is properly documented

Security & Performance

No obvious security flaws
No notable performance decrease

Patrick Schönfeld added 2 commits

July 9, 2022 11:14

1.6

312a953

1.6

d4d324f

patrickjaja merged commit e2bb9ac into main

pwnyprod deleted the refactor branch

July 14, 2022 12:28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment