fix: fix WindowScrolling class

nexxtway · Oct 12, 2020 · db793d2 · db793d2
1 parent 0a3c1c4
commit db793d2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/src/components/Picklist/index.js b/src/components/Picklist/index.js
@@ -73,8 +73,6 @@ class Picklist extends Component {
         if (!wasOpen && isOpen) {
             this.outsideClick.startListening(this.containerRef.current, () => this.closeMenu());
             this.windowScrolling.startListening(this.handleWindowScroll);
-        } else if (wasOpen && !isOpen) {
-            this.windowScrolling.stopListening();
         }
     }
 
@@ -124,6 +122,7 @@ class Picklist extends Component {
 
     closeMenu() {
         this.outsideClick.stopListening();
+        this.windowScrolling.stopListening();
         this.setState({
             isOpen: false,
         });

diff --git a/src/libs/scrollController/windowScrolling.js b/src/libs/scrollController/windowScrolling.js
@@ -11,7 +11,7 @@ class WindowScrolling {
     [privateHandleScroll](event) {
         if (!this.isTicking) {
             window.requestAnimationFrame(() => {
-                this.callback(this.callback(this, event));
+                this.callback(this, event);
                 this.isTicking = false;
             });
             this.isTicking = true;