Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: TimePicker am/pm select when clicking on the selected element #1475

Closed
TahimiLeonBravo opened this issue Apr 10, 2020 · 9 comments · Fixed by #1663
Closed

fix: TimePicker am/pm select when clicking on the selected element #1475

TahimiLeonBravo opened this issue Apr 10, 2020 · 9 comments · Fixed by #1663
Labels
2 coins bug Something isn't working

Comments

@TahimiLeonBravo
Copy link
Collaborator

TahimiLeonBravo commented Apr 10, 2020

https://drive.google.com/drive/u/2/folders/1rZEIq4TxqbFkdyaCu8g-Sh7Zym1dHaBJ

Steps to reproduce

  1. Go to TimePicker component https://react-rainbow.io/#!/TimePicker/3
  2. Click on the TimePicker input
  3. Click on the "PM" element

Current Behavior

When clicking on the selected element on the "AM-PM" it doesn't close.

Expected Behavior

When clicking any element on the "AM-PM" it should close them

@TahimiLeonBravo TahimiLeonBravo created this issue from a note in React Rainbow Components (Backlog (not ready)) Apr 10, 2020
@TahimiLeonBravo TahimiLeonBravo added the bug Something isn't working label Apr 10, 2020
@Anyrob
Copy link
Contributor

Anyrob commented Jun 24, 2020

Hi! I sent request access for the added document,
meanwhile, would you mind giving me more context about it?

@TahimiLeonBravo
Copy link
Collaborator Author

Hi @Anyrob the bug happens when you try clicking on the selected value on the "am-pm", I am going to add the steps to reproduce the bug and the expected behavior

@Anyrob
Copy link
Contributor

Anyrob commented Jun 24, 2020

Thank you! I would like to work on this one :)

@TahimiLeonBravo
Copy link
Collaborator Author

Thank you! I would like to work on this one :)

Great!! you are welcome!!

@Anyrob
Copy link
Contributor

Anyrob commented Jun 25, 2020

Hi @TahimiLeonBravo I think I solve it :) I'm gonna make my PR soon, but I noticed another bug, should I write it here?

@TahimiLeonBravo
Copy link
Collaborator Author

TahimiLeonBravo commented Jun 25, 2020

Great! @Anyrob I think you should make a PR with this fix and create a new issue for the new bug 👍

@Anyrob
Copy link
Contributor

Anyrob commented Jun 25, 2020

Hey! @TahimiLeonBravo, I'm experiencing some problems with my internet connection but as soon as it is restored I'll make the PR! :)

@Anyrob
Copy link
Contributor

Anyrob commented Jun 26, 2020

Hi @TahimiLeonBravo just to notify you that my internet is better now :), and also, that I was trying to do the integration test before the PR, but I couldn't do it. I already identified where to write (Integration-specs-TimePicker-TimePricker-1.specs.js) and I was analyzing the ones that are there, however, I'm not being able to prove that it's working as expected. I already have a gif that shows the issue being solved, but I don't know if it's enough to show that it works. That's my only blocker to submit the PR, Do you have any recommendations for me?

@LeandroTorresSicilia
Copy link
Member

Submit the PR without the test, we can create another issue to test it later

React Rainbow Components automation moved this from Backlog (not ready) to QA Jul 27, 2020
@TahimiLeonBravo TahimiLeonBravo moved this from QA to Done in React Rainbow Components Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 coins bug Something isn't working
Projects
Development

Successfully merging a pull request may close this issue.

3 participants