fix: close AM / PM element by selecting #1663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ContributorsCommit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
|
|
TahimiLeonBravo
changed the title
TahimiLeonBravo
approved these changes
Jun 27, 2020
|
@Anyrob Good Job!! |
Anyrob
force-pushed
the
ampm-element-close-automatically
branch
from
dd524cb
to
566e998
Compare
|
Hi @TahimiLeonBravo, I already check the CLA, but it wasn't updating so I made another commit, and this time it works! Please let me know if there's another thing I need to do (: |
12 tasks
12 tasks
Anyrob
force-pushed
the
ampm-element-close-automatically
branch
2 times, most recently
from
927b4f1
to
b99d304
Compare
Anyrob
force-pushed
the
ampm-element-close-automatically
branch
from
b99d304
to
84df8a1
Compare
|
@TahimiLeonBravo I made the change suggested by @LeandroTorresSicilia 👍 I think that's all if there is anything else pending please let me know |
| @@ -49,8 +49,7 @@ export default class AmPmSelect extends PureComponent { | |||
| } | |||
|
|
|||
| render() { | |||
| const { isFocused } = this.props; | |||
| const { tabIndex, onFocus, value } = this.props; | |||
| const { isFocused, tabIndex, onFocus, value, onClick } = this.props; | |||
LeandroTorresSicilia
approved these changes
Jun 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close AM / PM element by selecting
fix: #1475
Changes proposed in this PR:
@nexxtway/react-rainbow