Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add prop icon to the FileSelector component #1800

Closed
5 tasks
TahimiLeonBravo opened this issue Sep 4, 2020 · 1 comment · Fixed by #1811
Closed
5 tasks

feat: add prop icon to the FileSelector component #1800

TahimiLeonBravo opened this issue Sep 4, 2020 · 1 comment · Fixed by #1811
Assignees
@rgah2107
Labels
2 coins new feature
Projects
React Rainbow Components

Comments

@TahimiLeonBravo
Copy link
Collaborator

TahimiLeonBravo commented Sep 4, 2020 •
edited
Loading

Specs

  • Implement new prop
  • Add test

Requirements

  • It should receive a node
  • It should render the current icon when the icon prop is not passed
  • Add a new InteractiveExample
    https://zpl.io/brZAnND

Usage

<FileSelector icon={<UploadImageIcon />} />
@TahimiLeonBravo TahimiLeonBravo created this issue from a note in React Rainbow Components (Todo (defined)) Sep 4, 2020
@bobbylemm
Copy link

Hello, I am new here and looking for a good first issue, this looks like a good one. If it has not been worked on, can I work on it?

@rgah2107 rgah2107 moved this from Todo (defined) to In progress in React Rainbow Components Sep 8, 2020
rgah2107 added a commit to rgah2107/react-rainbow that referenced this issue Sep 8, 2020
@rgah2107
feat: add prop icon to the FileSelector component
ba74d21 
fix: nexxtway#1800
@rgah2107 rgah2107 mentioned this issue Sep 8, 2020
Merged
1 task
@rgah2107 rgah2107 moved this from In progress to Done in React Rainbow Components Sep 8, 2020
@rgah2107 rgah2107 moved this from Done to Code Review in React Rainbow Components Sep 8, 2020
React Rainbow Components automation moved this from Code Review to QA Sep 11, 2020
TahimiLeonBravo added a commit that referenced this issue Sep 11, 2020
@rgah2107 @TahimiLeonBravo @LeandroTorresSicilia
feat: add prop icon to the FileSelector component (#1811)
928fce2 
* feat: add prop icon to the FileSelector component

fix: #1800

* fix: change prop description

Co-authored-by: Tahimi <tahimileon@gmail.com>
Co-authored-by: Jose Leandro Torres <jtorressicilia@gmail.com>
@TahimiLeonBravo TahimiLeonBravo moved this from QA to Done in React Rainbow Components Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rgah2107 rgah2107

Labels
2 coins new feature
Projects
React Rainbow Components
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add prop icon to the FileSelector component rgah2107/react-rainbow
3 participants
@TahimiLeonBravo @bobbylemm @rgah2107