Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add labelAlignment prop to the Input component #1823

Closed
6 tasks
TahimiLeonBravo opened this issue Sep 14, 2020 · 0 comments · Fixed by #1828
Closed
6 tasks

feat: add labelAlignment prop to the Input component #1823

TahimiLeonBravo opened this issue Sep 14, 2020 · 0 comments · Fixed by #1828
Assignees
@rgah2107
Labels
2 coins new feature
Projects
React Rainbow Components

Comments

@TahimiLeonBravo
Copy link
Collaborator

TahimiLeonBravo commented Sep 14, 2020 •
edited by rgah2107
Loading

Specs

  • implement functionality
  • add tests
  • add interactive example

Requirements

  • It should have a labelAlignment prop to control the position of the label
  • It should receive the center | right | left values
  • The default value should be center
@TahimiLeonBravo TahimiLeonBravo created this issue from a note in React Rainbow Components (Todo (defined)) Sep 14, 2020
@rgah2107 rgah2107 moved this from Todo (defined) to In progress in React Rainbow Components Sep 16, 2020
rgah2107 added a commit to rgah2107/react-rainbow that referenced this issue Sep 16, 2020
@rgah2107
feat: add labelAlignment prop to the Input component
f143c6b 
fix: nexxtway#1823
@rgah2107 rgah2107 mentioned this issue Sep 16, 2020
Merged
1 task
@rgah2107 rgah2107 moved this from In progress to Done in React Rainbow Components Sep 16, 2020
@rgah2107 rgah2107 moved this from Done to Code Review in React Rainbow Components Sep 16, 2020
@rgah2107 rgah2107 moved this from Code Review to In progress in React Rainbow Components Sep 16, 2020
@rgah2107 rgah2107 moved this from In progress to Done in React Rainbow Components Sep 17, 2020
@rgah2107 rgah2107 moved this from Done to Code Review in React Rainbow Components Sep 17, 2020
React Rainbow Components automation moved this from Code Review to QA Sep 19, 2020
TahimiLeonBravo pushed a commit that referenced this issue Sep 19, 2020
@rgah2107
feat: add labelAlignment prop to the Input component (#1828)
f0ba1e3 
* feat: add labelAlignment prop to the Input component

fix: #1823

* fix: change the solution to avoid modifying the Label component

* fix: indentation problem
@TahimiLeonBravo TahimiLeonBravo moved this from QA to Done in React Rainbow Components Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rgah2107 rgah2107

Labels
2 coins new feature
Projects
React Rainbow Components
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add labelAlignment prop to the Input component rgah2107/react-rainbow
2 participants
@TahimiLeonBravo @rgah2107