Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add orientation prop on the RadioGroup and CheckboxGroup components #1824

Closed
6 tasks
TahimiLeonBravo opened this issue Sep 14, 2020 · 2 comments · Fixed by #1834
Closed
6 tasks

feat: add orientation prop on the RadioGroup and CheckboxGroup components #1824

TahimiLeonBravo opened this issue Sep 14, 2020 · 2 comments · Fixed by #1834
Labels
2 coins new feature
Projects
React Rainbow Components

Comments

@TahimiLeonBravo
Copy link
Collaborator

TahimiLeonBravo commented Sep 14, 2020 •
edited
Loading

Specs

  • implement functionality
  • add tests
  • add interactive example

Requirements

  • It should have an orientation pop to control the position of the options on the components
  • It should receive de vertical | horizontal values
  • The default value should be vertical
@TahimiLeonBravo TahimiLeonBravo created this issue from a note in React Rainbow Components (Todo (defined)) Sep 14, 2020
luisFilipePT added a commit to luisFilipePT/react-rainbow that referenced this issue Sep 19, 2020
@luisFilipePT
feat(radiogroup): add suport to horizontal orientation
ab3fed6 
Add suport to horizontal orientation by adding a new optional orientation prop (default vertical)

closes nexxtway#1824
luisFilipePT added a commit to luisFilipePT/react-rainbow that referenced this issue Sep 19, 2020
@luisFilipePT
feat(checkboxgroup): add orientation prop to checkbox group
b7192b1 
Add optional orientation prop to checkbox group (default vertical)

closes nexxtway#1824
@luisFilipePT luisFilipePT mentioned this issue Sep 19, 2020
Merged
1 task
@luisFilipePT
Copy link
Contributor

@TahimiLeonBravo opened a pr for this issue, hope you don't mind 😊

I don't agree with codeclimate so I will leave the suggestions open.

image

Anything to change or improve just let me know

Thanks 🙌

@TahimiLeonBravo
Copy link
Collaborator Author

@TahimiLeonBravo opened a pr for this issue, hope you don't mind 😊

I don't agree with codeclimate so I will leave the suggestions open.

image

Anything to change or improve just let me know

Thanks 🙌

Hello @luisFilipePT Thanks for collaborating in react-rainbow

@TahimiLeonBravo TahimiLeonBravo moved this from Todo (defined) to In progress in React Rainbow Components Sep 19, 2020
React Rainbow Components automation moved this from In progress to QA Sep 19, 2020
TahimiLeonBravo pushed a commit that referenced this issue Sep 19, 2020
@luisFilipePT @LeandroTorresSicilia
feat: add orientation prop on the RadioGroup and CheckboxGroup …
15c6c7a 
…components (#1834)

* feat(radiogroup): add suport to horizontal orientation

Add suport to horizontal orientation by adding a new optional orientation prop (default vertical)

closes #1824

* revert changes to package.json

* feat(checkboxgroup): add orientation prop to checkbox group

Add optional orientation prop to checkbox group (default vertical)

closes #1824

* Delete empty line refered by circleCI

* refactor(radio and checkbox groups): move examples to hooks

Move examples to hooks and add better typescript definition

ref #1834

* Fix word to improve test's description

Co-authored-by: Jose Leandro Torres <jtorressicilia@gmail.com>
@TahimiLeonBravo TahimiLeonBravo moved this from QA to Done in React Rainbow Components Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2 coins new feature
Projects
React Rainbow Components
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add orientation prop on the RadioGroup and CheckboxGroup components luisFilipePT/react-rainbow
2 participants
@luisFilipePT @TahimiLeonBravo