Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text-transform Capitalize applied to Datetime leads to weird styling #2209

Closed
1 task done
zackdotcomputer opened this issue Mar 30, 2021 · 0 comments · Fixed by #2279
Closed
1 task done

Text-transform Capitalize applied to Datetime leads to weird styling #2209

zackdotcomputer opened this issue Mar 30, 2021 · 0 comments · Fixed by #2279
Assignees
Labels
1 coin bug Something isn't working

Comments

@zackdotcomputer
Copy link

zackdotcomputer commented Mar 30, 2021

  • I have searched the issues of this repository and believe that this is not a duplicate.

Describe the bug

For reasons I'm unsure of, this file applies text-transform: capitalize to the DateTimePicker's input field. This overpowers the localization the field already gets and leads to weird styling like "2:54 Pm" rather than the more acceptable PM or pm.

Screenshots

Current:
Screen Shot 2021-03-30 at 15 06 32

Desired:
Screen Shot 2021-03-30 at 15 04 38

Expected Behavior 🤔

Field value should be localized properly

Current Behavior 😯

Field value is localized and then text-transformed to a value that looks "wrong"

Possible Solution

Remove the text-transform, which doesn't serve a clear purpose. If it does serve a clear purpose, provide a way to override or disable it.

@zackdotcomputer zackdotcomputer added the bug Something isn't working label Mar 30, 2021
@TahimiLeonBravo TahimiLeonBravo added this to Todo (defined) in React Rainbow Components via automation Apr 6, 2021
React Rainbow Components automation moved this from Todo (defined) to QA Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 coin bug Something isn't working
Development

Successfully merging a pull request may close this issue.

4 participants