Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix DateTimePicker text capitalization #2279

Merged
merged 4 commits into from Sep 17, 2021

Conversation

HellWolf93
Copy link
Collaborator

fix: #2209

Changes proposed in this PR:

@commit-lint
Copy link

commit-lint bot commented Sep 16, 2021

Bug Fixes

  • fix DateTimePicker text capitalization (e897ee5)
  • remove capitalization (35079e6)

Contributors

HellWolf93, TahimiLeonBravo, LeandroTorresSicilia

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@github-actions
Copy link

github-actions bot commented Sep 16, 2021

Visit the preview URL for this PR (updated for commit 5d85b24):

https://react-rainbow--pr2279-fix-datetimeinput-ca-skj2clq1.web.app

(expires Fri, 24 Sep 2021 19:12:09 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@LeandroTorresSicilia
Copy link
Member

@HellWolf93 here simply remove text-transform: capitalize;

@codeclimate
Copy link

codeclimate bot commented Sep 17, 2021

Code Climate has analyzed commit 35079e6 and detected 0 issues on this pull request.

View more on Code Climate.

@LeandroTorresSicilia LeandroTorresSicilia merged commit 7ebabb6 into master Sep 17, 2021
@LeandroTorresSicilia LeandroTorresSicilia deleted the fix-datetimeinput-capitalize branch September 17, 2021 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text-transform Capitalize applied to Datetime leads to weird styling
3 participants