Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate styled-components #950

Closed
1 task done
gustavopch opened this issue Sep 17, 2019 · 3 comments
Closed
1 task done

feat: migrate styled-components #950

gustavopch opened this issue Sep 17, 2019 · 3 comments

Comments

@gustavopch
Copy link

gustavopch commented Sep 17, 2019

I think this lib would benefit from using styled-components instead of SCSS.

  • I have searched the issues of this repository and believe that this is not a duplicate.

Is your feature request related to a problem? Please describe.
No, not related to a problem. It's an improvement.

Expected Behavior 🤔

Not about behavior but architecture.

Context 🔦

By using styled-components, this lib would be able to:

  • Stop having duplicated CSS and SCSS files everywhere.
  • Remove className helper functions from components (getClassNames, getVariantClassNames etc) as you can inject props into styled-components.
  • Stop worrying about vendor prefixes.
  • Stop worrying about naming conflicts (I know BEM solves that problem, but it's even better when a problem doesn't even exist in the first place).
  • Better theming support as styled-components generates CSS dynamically and theming is supported out-of-the-box with Context API.
  • By the way, no need to build anything.
  • Basically, a lot less lines of code which generally means less room for bugs and more productivity.

Describe the solution you'd like
Basically replacing CSS/SCSS by styled-components.

Describe alternatives you've considered
I haven't considered other alternatives.

@reiniergs
Copy link
Collaborator

styled-components are pretty cool, that's something we should consider, at least new components should use it, replacing CSS/SCSS by styled-components is a major refactor in our codebase at this point.

@LeandroTorresSicilia
Copy link
Member

LeandroTorresSicilia commented Sep 21, 2019

We will refactor all components to use styled-components, here is the first one:
#981
Anyone can help us to make this move with small contributions

@TahimiLeonBravo
Copy link
Collaborator

TahimiLeonBravo commented Sep 21, 2019

Components list to migrate

@TahimiLeonBravo TahimiLeonBravo changed the title feat: use styled-components feat: migrate styled-components Oct 23, 2019
@TahimiLeonBravo TahimiLeonBravo pinned this issue Oct 23, 2019
@TahimiLeonBravo TahimiLeonBravo unpinned this issue Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

4 participants