New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrate styled-components #950
Labels
Projects
Comments
styled-components are pretty cool, that's something we should consider, at least new components should use it, replacing CSS/SCSS by styled-components is a major refactor in our codebase at this point. |
We will refactor all components to use styled-components, here is the first one: |
1 task
This was referenced Sep 25, 2019
This was referenced Sep 30, 2019
This was referenced Oct 8, 2019
This was referenced Oct 14, 2019
1 task
TahimiLeonBravo
changed the title
feat: use styled-components
feat: migrate styled-components
Oct 23, 2019
1 task
This was referenced Nov 7, 2019
1 task
This was referenced Nov 15, 2019
This was referenced Nov 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I think this lib would benefit from using styled-components instead of SCSS.
Is your feature request related to a problem? Please describe.
No, not related to a problem. It's an improvement.
Expected Behavior 🤔
Not about behavior but architecture.
Context 🔦
By using styled-components, this lib would be able to:
getClassNames
,getVariantClassNames
etc) as you can inject props into styled-components.Describe the solution you'd like
Basically replacing CSS/SCSS by styled-components.
Describe alternatives you've considered
I haven't considered other alternatives.
The text was updated successfully, but these errors were encountered: