refactor: migrate button styled components #1062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| &[disabled] { | ||
| background-color: ${props.isLoading ? 'COLOR_WHITE' : 'transparent'}; |
There was a problem hiding this comment.
use COLOR_WHITE constant without ' ' because here it converts to this css:
background-color: COLOR_WHITE and there is not COLOR_WHITE color so use:
background-color: ${props.isLoading ? COLOR_WHITE : 'transparent'};
change in all places
| props.shaded && | ||
| ` | ||
| box-shadow: ${SHADOW_1}; | ||
| `}; |
There was a problem hiding this comment.
here when there is only one line of styles you can:
${props => props.shaded && `box-shadow: ${SHADOW_1};`
LeandroTorresSicilia
approved these changes
Oct 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#950
Changes proposed in this PR:
Migrate Button to styled-components
I have followed (at least) the PR section of the contributing guide.
@nexxtway/react-rainbow