Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add prop size to VisualPicker component #1527

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/components/VisualPicker/index.d.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { ReactNode, ComponentType } from 'react';
import { BaseProps } from '../types';
import { BaseProps, VisualPickerSize } from '../types';

type Value = string[] | string;

Expand All @@ -13,6 +13,7 @@ export interface VisualPickerProps extends BaseProps {
error?: ReactNode;
children?: ReactNode;
multiple?: boolean;
size?: VisualPickerSize;
}

declare const VisualPicker: React.ComponentType<VisualPickerProps>;
Expand Down
6 changes: 6 additions & 0 deletions src/components/VisualPicker/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -56,13 +56,15 @@ class VisualPicker extends Component {
value,
multiple,
className,
size,
} = this.props;
const context = {
ariaDescribedby: this.getErrorMessageId(),
groupName: this.groupNameId,
privateOnChange: this.handleChange,
value,
multiple,
size,
};

return (
Expand Down Expand Up @@ -103,6 +105,9 @@ VisualPicker.propTypes = {
className: PropTypes.string,
/** It is an object with custom style applied to the root element. */
style: PropTypes.object,
/** The size of the VisualPicker. Valid values are small, medium, and large.
* This value defaults to medium. */
size: PropTypes.oneOf(['small', 'medium', 'large']),
/**
* This prop that should not be visible in the documentation.
* @ignore
Expand All @@ -122,6 +127,7 @@ VisualPicker.defaultProps = {
error: null,
className: undefined,
style: undefined,
size: 'medium',
children: [],
multiple: false,
};
Expand Down
142 changes: 142 additions & 0 deletions src/components/VisualPicker/readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -243,3 +243,145 @@ class SimpleVisualPickerWithFooter extends React.Component {
<SimpleVisualPickerWithFooter />
</div>
```

##### VisualPicker small

```js
import React from 'react';
import { VisualPicker, VisualPickerOption } from 'react-rainbow-components';
import styled from 'styled-components';

const StyledHeader = styled.h1.attrs(props => {
return props.theme.rainbow.palette;
})`
font-size: 24px;
font-weight: 300;
color: ${props => props.text.main};
`;

const StyledLabel = styled.h2.attrs(props => {
return props.theme.rainbow.palette;
})`
font-size: 12px;
font-weight: 300;
margin-top:6px
color: ${props => props.text.label};
`;

class SimpleVisualPicker extends React.Component {
constructor(props) {
super(props);
this.state = {
value: null,
};
this.handleOnChange = this.handleOnChange.bind(this);
}

handleOnChange(value) {
return this.setState({ value });
}

render() {
return (
<VisualPicker
id="visual-picker-component-7"
label="Select Option"
value={this.state.value}
onChange={this.handleOnChange}
size="small"
>
<VisualPickerOption name="option-1">
<DesignIcon />
<StyledLabel>Design</StyledLabel>
</VisualPickerOption>
<VisualPickerOption name="option-2">
<PhotographerIcon />
<StyledLabel>Photographer</StyledLabel>
</VisualPickerOption>
<VisualPickerOption name="option-3">
<CodeIcon />
<StyledLabel>Programmer</StyledLabel>
</VisualPickerOption>
</VisualPicker>
);
}
}

<div className="rainbow-align-content_center rainbow-m-around_xx-large rainbow-flex_column">
<StyledHeader className="rainbow-m-bottom_medium">
What are you doing?
</StyledHeader>
<SimpleVisualPicker />
</div>
```

##### VisualPicker large

```js
import React from 'react';
import { VisualPicker, VisualPickerOption } from 'react-rainbow-components';
import styled from 'styled-components';

const StyledHeader = styled.h1.attrs(props => {
return props.theme.rainbow.palette;
})`
font-size: 24px;
font-weight: 300;
color: ${props => props.text.main};
`;

const StyledLabel = styled.h2.attrs(props => {
return props.theme.rainbow.palette;
})`
font-size: 15px;
font-weight: 300;
margin-top:6px
color: ${props => props.text.label};
`;

class SimpleVisualPicker extends React.Component {
constructor(props) {
super(props);
this.state = {
value: null,
};
this.handleOnChange = this.handleOnChange.bind(this);
}

handleOnChange(value) {
return this.setState({ value });
}

render() {
return (
<VisualPicker
id="visual-picker-component-9"
label="Select Option"
value={this.state.value}
onChange={this.handleOnChange}
size="large"
>
<VisualPickerOption name="option-1">
<DesignIcon />
<StyledLabel>Design</StyledLabel>
</VisualPickerOption>
<VisualPickerOption name="option-2">
<PhotographerIcon />
<StyledLabel>Photographer</StyledLabel>
</VisualPickerOption>
<VisualPickerOption name="option-3">
<CodeIcon />
<StyledLabel>Programmer</StyledLabel>
</VisualPickerOption>
</VisualPicker>
);
}
}

<div className="rainbow-align-content_center rainbow-m-around_xx-large rainbow-flex_column">
<StyledHeader className="rainbow-m-bottom_medium">
What are you doing?
</StyledHeader>
<SimpleVisualPicker />
</div>
```
4 changes: 2 additions & 2 deletions src/components/VisualPickerOption/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ class PickerOption extends Component {
}

render() {
const { disabled, children, footer, style, className } = this.props;
const { disabled, children, footer, style, className, size } = this.props;
const { groupName, ariaDescribedby } = this.props;

return (
Expand All @@ -63,7 +63,7 @@ class PickerOption extends Component {
/>

<StyledLabel data-id="visual-picker_option-label" htmlFor={this.inputId}>
<StyledContent data-id="visual-picker_option">
<StyledContent data-id="visual-picker_option" size={size}>
<RenderIf isTrue={this.isChecked()}>
<StyledCheckedTriangle />
<StyledCheckmarkIcon />
Expand Down
5 changes: 3 additions & 2 deletions src/components/VisualPickerOption/styled/content.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
import styled from 'styled-components';
import attachThemeAttrs from '../../../styles/helpers/attachThemeAttrs';

const sizeMap = { large: '210px', medium: '142px', small: '100px' };
const StyledContent = attachThemeAttrs(styled.span)`
height: 142px;
width: 100%;
height: ${props => sizeMap[props.size] || sizeMap.medium};
width: ${props => sizeMap[props.size] || sizeMap.medium};
border-radius: 22px;
box-shadow: ${props => props.shadows.shadow_4};
border: solid 2px ${props => props.palette.border.divider};
Expand Down
2 changes: 1 addition & 1 deletion src/components/VisualPickerOption/styled/label.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ import styled from 'styled-components';
const StyledLabel = styled.label`
display: flex;
flex-direction: column;
width: 142px;
box-sizing: border-box;
align-items: center;
`;

export default StyledLabel;
1 change: 1 addition & 0 deletions src/components/types.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ export type ButtonIconVariant =
| 'border-filled'
| 'border-inverse'
| 'inverse';
export type VisualPickerSize = 'small' | 'medium' | 'large';

export type IconPosition = 'left' | 'right';

Expand Down