fix: codeInput implement specs, code improvement and new readme examples #1538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug Fixes
FeaturesStylesContributors@blakmetall, @TahimiLeonBravo, @LeandroTorresSicilia Commit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
ghost
requested review from
…y areas on it, will be on stand by
ghost
changed the title
* margin bottom added to single inputs for responsive * id assignation based on baseID * readme -- example components renamed accordingly and fixes * react library hooks installation
* added handler for focus and click to be able to blur inputs when codeInput is readOnly or disabled * added disabled and error examples into readme file
ghost
commented
May 14, 2020
…pdated (onChange) * getNormalizedValue improved to be use his result for to validate updated value * unnecessary click handler removed, it was needed for focus action on click for disabled and readOnly items. Is not necessary anymore.
src/components/CodeInput/hooks/__test__/usePreviousIndex.spec.js
Outdated
Show resolved
Hide resolved
* removed manual await
* change how we type automatically letters and numbers from .key(['','2']) to .key('2')
* extra specs added
* return undefined instead of -1 flag for not found elements
* removed unnecessary specs for now: input id specs
* hook spec for usePreviousIndex definition changed (it was not right before)
* name prop removed
* input id's removed
|
@blakmetall I added a design for readOnly appearance, let's follow these styles |
TahimiLeonBravo
requested changes
May 15, 2020
…em as much as possible due to margin-bottom style for inputs
|
@blakmetall we need fix some tests here in order to merge this PR |
* typeKey method added to PageObject to manage key event * integration test added for the testing over the disabled component * onClick handler added to allow to blur when readOnly is true; * improved the detection of the current focused index; controls added for the hook useFocusedIndexState: disabled and readOnly f * specs updated for useFocusedIndexState hook * removed .select() for selection on setFocus method, not needed anymore and to avoid visual selection over a readOnly CodeInput
* type method from pageObject updated * spec removed for readOnly verification (not needed anymore) * readOnly styled configuration update * update over onClick event * removal of unnecessary condition related to readOnly (not needed anymore)
|
|
Note: integration tests failed over another Component unrelated tu CodeInput
|
…ty-and-a-few-improvements
LeandroTorresSicilia
approved these changes
May 22, 2020
LeandroTorresSicilia
deleted the
fix-codeinput-component-improve-accesibility-and-a-few-improvements
branch
79 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #1488
fix: codeInput accessibility, a few code improvements and readme examples added