feat: add prop size to the RadioButtonGroup component #1541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Features
Bug FixesContributors |
yvmunayev
reviewed
May 14, 2020
Comment on lines
-18
to
+42
| font-size: ${FONT_SIZE_TEXT_LARGE}; | ||
| font-size: ${props => fontSizeMap[props.size] || fontSizeMap.medium}; | ||
| color: ${props => props.inverseLabel}; | ||
| padding: 0 ${PADDING_LARGE}; | ||
| padding: 0 ${props => paddingMap[props.size] || paddingMap.medium}; |
There was a problem hiding this comment.
@TahimiLeonBravo checks here that the size is being changed.
There was a problem hiding this comment.
@yvmunayev @rgah2107 I agree with this size changes +1
Comment on lines
6
to
14
| const sizeMap = { large: '3.1rem', medium: '2.6rem', small: '1.76rem', 'x-small': '1.26rem' }; | ||
| const StyledMarker = attachThemeAttrs(styled.span)` | ||
| position: absolute; | ||
| background: ${props => props.palette.background.main}; | ||
| opacity: 0; | ||
| top: 0; | ||
| bottom: 0; | ||
| margin: auto; | ||
| height: 2.6rem; | ||
| height: ${props => sizeMap[props.size] || sizeMap.medium}; |
There was a problem hiding this comment.
@TahimiLeonBravo will be able to change to 2.5rem here?
There was a problem hiding this comment.
@rgah2107 @yvmunayev 2.6rem is right because we need to make the marker a little higher than the container.
Also, we need to change by small='1.8rem' and 'x-small': '1.3rem' because right now this is not centered vertically
TahimiLeonBravo
requested changes
May 17, 2020
| }; | ||
| const paddingMap = { | ||
| large: PADDING_LARGE, | ||
| medium: PADDING_MEDIUM, |
There was a problem hiding this comment.
let's use for
medium: PADDING_LARGE
large: PADDING_X_LARGE
LeandroTorresSicilia
approved these changes
May 17, 2020
TahimiLeonBravo
approved these changes
May 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #1537
Changes proposed in this PR:
add prop size to the
RadioButtonGroupcomponentI have followed (at least) the PR section of the contributing guide.
@nexxtway/react-rainbow