-
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add selectionType prop to Calendar component #1563
Merged
maxxgreene
merged 30 commits into
master
from
feat-add-selection-type-prop-to-calendar-component
May 22, 2020
Merged
feat: add selectionType prop to Calendar component #1563
maxxgreene
merged 30 commits into
master
from
feat-add-selection-type-prop-to-calendar-component
May 22, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Features
Bug Fixes
Styles
StylesContributors |
wildergd
force-pushed
the
feat-add-selection-type-prop-to-calendar-component
branch
from
May 20, 2020 04:16
ebad476
to
0f310df
Compare
wildergd
force-pushed
the
feat-add-selection-type-prop-to-calendar-component
branch
from
May 20, 2020 04:34
0f310df
to
17a5bf4
Compare
yvmunayev
reviewed
May 20, 2020
wildergd
force-pushed
the
feat-add-selection-type-prop-to-calendar-component
branch
from
May 20, 2020 21:07
3008690
to
f7b783b
Compare
@wildergd I think we should use colors with opacity here like an RGBA with a value on the opacity different of 1 |
wildergd
force-pushed
the
feat-add-selection-type-prop-to-calendar-component
branch
from
May 22, 2020 18:06
c13e983
to
bc587ad
Compare
…ttps://github.com/nexxtway/react-rainbow into feat-add-selection-type-prop-to-calendar-component
TahimiLeonBravo
approved these changes
May 22, 2020
…ttps://github.com/90milesbridge/react-rainbow into feat-add-selection-type-prop-to-calendar-component
maxxgreene
reviewed
May 22, 2020
maxxgreene
reviewed
May 22, 2020
The implementation looks good to me, I would say the helpers should be written avoiding (!) in conditions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #1553
Changes proposed in this PR:
add selectionType prop to Calendar component
I have followed (at least) the PR section of the contributing guide.
@nexxtway/react-rainbow