Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add selectionType prop to Calendar component #1563

Merged
merged 30 commits into from
May 22, 2020

Conversation

wildergd
Copy link
Collaborator

fix: #1553

Changes proposed in this PR:

@nexxtway/react-rainbow

@commit-lint
Copy link

commit-lint bot commented May 19, 2020

Features

  • add selectionType prop to Calendar component (c4004e6)

Bug Fixes

  • code cleanup (b26ac84)
  • fix render when selection type is range (fa21005)
  • fix range highlight when hovered (6cefaa6)
  • fix comments (f396a8e)
  • some code enhancements (b3b3bc9)
  • fix index.d.ts (f62c06d)
  • issues in comments (4d33c7f)
  • fix buildNewRangeFromValue helper (bc587ad)
  • indentation (71923b2)
  • fix range selection when selected end date is previous to range start date (4839b77)
  • fix comments (746feaa)

Styles

  • fix range highlight (6130642)
  • fix range highlight (7eb649e)
  • fix range highlight when range start date is the same as range end date (1b4fc06)
  • fix styles (17a5bf4)
  • fix highlight background when range starts on saturday and end in sunday (2e3077e)

Styles

Contributors

@wildergd, @TahimiLeonBravo, @maxxgreene

@wildergd wildergd added the WIP work in progress label May 19, 2020
@wildergd wildergd force-pushed the feat-add-selection-type-prop-to-calendar-component branch from ebad476 to 0f310df Compare May 20, 2020 04:16
@wildergd wildergd force-pushed the feat-add-selection-type-prop-to-calendar-component branch from 0f310df to 17a5bf4 Compare May 20, 2020 04:34
src/components/Calendar/day.js Outdated Show resolved Hide resolved
src/components/Calendar/hooks/useDaysBuilder.js Outdated Show resolved Hide resolved
src/components/Calendar/day.js Outdated Show resolved Hide resolved
src/components/Calendar/hooks/useCurrentDateFromValue.js Outdated Show resolved Hide resolved
src/components/Calendar/hooks/useRangeFromValue.js Outdated Show resolved Hide resolved
src/components/Calendar/index.js Outdated Show resolved Hide resolved
src/components/Calendar/week.js Outdated Show resolved Hide resolved
src/components/Calendar/index.js Outdated Show resolved Hide resolved
@wildergd wildergd requested a review from yvmunayev May 20, 2020 14:13
@wildergd wildergd removed the WIP work in progress label May 20, 2020
@wildergd wildergd force-pushed the feat-add-selection-type-prop-to-calendar-component branch from 3008690 to f7b783b Compare May 20, 2020 21:07
@LeandroTorresSicilia
Copy link
Member

There is an issue with the dark theme:
Screen Shot 2020-05-21 at 11 40 17 PM

@TahimiLeonBravo
Copy link
Collaborator

There is an issue with the dark theme:
Screen Shot 2020-05-21 at 11 40 17 PM

@wildergd I think we should use colors with opacity here like an RGBA with a value on the opacity different of 1

@wildergd wildergd force-pushed the feat-add-selection-type-prop-to-calendar-component branch from c13e983 to bc587ad Compare May 22, 2020 18:06
@maxxgreene
Copy link
Contributor

The implementation looks good to me, I would say the helpers should be written avoiding (!) in conditions.

@maxxgreene maxxgreene merged commit 18a894f into master May 22, 2020
@maxxgreene maxxgreene deleted the feat-add-selection-type-prop-to-calendar-component branch May 22, 2020 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add the selectionType prop to the Calendar component
5 participants